diff mbox

[ovs-dev] packaging: Remove PyQt4 dependency.

Message ID 20160715005346.22027-1-joe@ovn.org
State Accepted
Headers show

Commit Message

Joe Stringer July 15, 2016, 12:53 a.m. UTC
This doesn't seem to have been necessary since ovsdbmonitor was removed
in commit 7868fbc6c97c ("ovsdbmonitor: Remove."). Drop the dependency.

Signed-off-by: Joe Stringer <joe@ovn.org>
---
 INSTALL.Fedora.md               | 2 +-
 Vagrantfile                     | 2 +-
 debian/control                  | 1 -
 rhel/openvswitch-fedora.spec.in | 2 +-
 4 files changed, 3 insertions(+), 4 deletions(-)

Comments

Ben Pfaff July 15, 2016, 3:29 p.m. UTC | #1
On Thu, Jul 14, 2016 at 05:53:46PM -0700, Joe Stringer wrote:
> This doesn't seem to have been necessary since ovsdbmonitor was removed
> in commit 7868fbc6c97c ("ovsdbmonitor: Remove."). Drop the dependency.
> 
> Signed-off-by: Joe Stringer <joe@ovn.org>

I didn't test this but I agree that qt isn't really needed.

Acked-by: Ben Pfaff <blp@ovn.org>
Joe Stringer July 15, 2016, 8:52 p.m. UTC | #2
On 15 July 2016 at 08:29, Ben Pfaff <blp@ovn.org> wrote:
> On Thu, Jul 14, 2016 at 05:53:46PM -0700, Joe Stringer wrote:
>> This doesn't seem to have been necessary since ovsdbmonitor was removed
>> in commit 7868fbc6c97c ("ovsdbmonitor: Remove."). Drop the dependency.
>>
>> Signed-off-by: Joe Stringer <joe@ovn.org>
>
> I didn't test this but I agree that qt isn't really needed.
>
> Acked-by: Ben Pfaff <blp@ovn.org>

Thanks, I applied this to master.
diff mbox

Patch

diff --git a/INSTALL.Fedora.md b/INSTALL.Fedora.md
index 12d9a72cd3bc..cb41d5c3f91f 100644
--- a/INSTALL.Fedora.md
+++ b/INSTALL.Fedora.md
@@ -18,7 +18,7 @@  documented in [INSTALL.md]. Specific packages (by package name) include:
   - rpm-build
   - autoconf automake libtool
   - systemd-units openssl openssl-devel
-  - python python-twisted-core python-zope-interface PyQt4 python-six
+  - python python-twisted-core python-zope-interface python-six
   - desktop-file-utils
   - groff graphviz
   - procps-ng
diff --git a/Vagrantfile b/Vagrantfile
index e618f9c1a30c..fb06b42ff95f 100644
--- a/Vagrantfile
+++ b/Vagrantfile
@@ -8,7 +8,7 @@  Vagrant.require_version ">=1.7.0"
 $bootstrap_fedora = <<SCRIPT
 dnf -y update
 dnf -y install autoconf automake openssl-devel libtool \
-               python-twisted-core python-zope-interface PyQt4 \
+               python-twisted-core python-zope-interface \
                desktop-file-utils groff graphviz rpmdevtools nc \
                wget python-six pyftpdlib checkpolicy selinux-policy-devel \
                libcap-ng-devel kernel-devel-`uname -r`
diff --git a/debian/control b/debian/control
index 2c07a73cd60f..a7685e501d2c 100644
--- a/debian/control
+++ b/debian/control
@@ -14,7 +14,6 @@  Build-Depends: graphviz,
                openssl,
                procps,
                python-all (>= 2.7),
-               python-qt4,
                python-twisted-conch,
                python-zopeinterface,
                python-six
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 16894b030e30..088afcb9e5e7 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora.spec.in
@@ -43,7 +43,7 @@  Source: http://openvswitch.org/releases/%{name}-%{version}.tar.gz
 
 BuildRequires: autoconf automake libtool
 BuildRequires: systemd-units openssl openssl-devel
-BuildRequires: python python-twisted-core python-zope-interface PyQt4 python-six
+BuildRequires: python python-twisted-core python-zope-interface python-six
 BuildRequires: desktop-file-utils
 BuildRequires: groff graphviz
 BuildRequires: checkpolicy, selinux-policy-devel