diff mbox series

[ovs-dev,v2] netdev-dpdk: Disable outer udp checksum offload for ice driver.

Message ID 1710901432-5206-1-git-send-email-junwang01@cestc.cn
State Changes Requested
Headers show
Series [ovs-dev,v2] netdev-dpdk: Disable outer udp checksum offload for ice driver. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation fail test: fail

Commit Message

Jun Wang March 20, 2024, 2:23 a.m. UTC 
Signed-off-by: Jun Wang <junwang01@cestc.cn>
---
 lib/netdev-dpdk.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Ilya Maximets March 20, 2024, 12:22 p.m. UTC | #1 
On 3/20/24 03:23, Jun Wang wrote:
> Signed-off-by: Jun Wang <junwang01@cestc.cn>

Hi.  Thanks for the patch!

Could you, please, add some information about the issue to the
commit message?

Following tags will also be appropriate to have:

Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
Reported-at: https://github.com/openvswitch/ovs-issues/issues/321

> ---
>  lib/netdev-dpdk.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index 29a6bf0..1820163 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -1354,6 +1354,12 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev)
>          info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_TCP_CKSUM;
>      }
>  
> +    if (!strcmp(info.driver_name, "net_ice")) {

Please, add a 'FIXME' or 'XXX' comment here stating that it is a
workaround that should be removed once there is a fix in DPDK.

Checkpatch will complain, but you may ignore that.

> +        VLOG_INFO("%s: disabled Tx outer udp checksum offloads for a "
> +                  "net/ice port.", netdev_get_name(&dev->up));
> +        info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
> +    }
> +
>      if (info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_IPV4_CKSUM) {
>          dev->hw_ol_features |= NETDEV_TX_IPV4_CKSUM_OFFLOAD;
>      } else {
Intel CI reported a failure, but it is a false negative.  Can
be ignored.

Best regards, Ilya Maximets.
diff mbox series

Patch

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 29a6bf0..1820163 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -1354,6 +1354,12 @@  dpdk_eth_dev_init(struct netdev_dpdk *dev)
         info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_TCP_CKSUM;
     }
 
+    if (!strcmp(info.driver_name, "net_ice")) {
+        VLOG_INFO("%s: disabled Tx outer udp checksum offloads for a "
+                  "net/ice port.", netdev_get_name(&dev->up));
+        info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
+    }
+
     if (info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_IPV4_CKSUM) {
         dev->hw_ol_features |= NETDEV_TX_IPV4_CKSUM_OFFLOAD;
     } else {