From patchwork Tue Dec 19 12:41:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eelco Chaudron X-Patchwork-Id: 1877931 X-Patchwork-Delegate: echaudro@redhat.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NXGOeCcn; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Svbtj02rlz20Gb for ; Tue, 19 Dec 2023 23:42:20 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2753082ED1; Tue, 19 Dec 2023 12:42:19 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2753082ED1 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NXGOeCcn X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZK1XE_Xgda6B; Tue, 19 Dec 2023 12:42:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 0B4A482EA5; Tue, 19 Dec 2023 12:42:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0B4A482EA5 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C7B5BC0072; Tue, 19 Dec 2023 12:42:16 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 34D19C0037 for ; Tue, 19 Dec 2023 12:42:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id C1A72435A6 for ; Tue, 19 Dec 2023 12:42:13 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org C1A72435A6 Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NXGOeCcn X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CH-3dQPoY7tM for ; Tue, 19 Dec 2023 12:42:12 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id A5CCD435A4 for ; Tue, 19 Dec 2023 12:42:12 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A5CCD435A4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702989731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AAcZUvTOp7Fu6TsWxzmXOBy81I7jixXBPPJn8ey9Z7c=; b=NXGOeCcnx5g7qZo8FOVCr/ld5Gyokclr18tscnUwrqmplotybn2mrBNcG/1mnvIjJBftYb +V1sjDewAvPuIFXKFmie13tieBAAz0c050vSyRf9C3csZofCpt3Ai+CgMJIuDyLKDo/UbY T+jgk7e2uoOonVAVBPXjRZt9krdAACw= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-4Qs74zJ9PFu9hsAOdGtD0g-1; Tue, 19 Dec 2023 07:42:07 -0500 X-MC-Unique: 4Qs74zJ9PFu9hsAOdGtD0g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 424CB3CBE320; Tue, 19 Dec 2023 12:42:07 +0000 (UTC) Received: from localhost.localdomain (unknown [10.39.193.139]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8DFB63C25; Tue, 19 Dec 2023 12:42:06 +0000 (UTC) From: Eelco Chaudron To: dev@openvswitch.org Date: Tue, 19 Dec 2023 13:41:58 +0100 Message-ID: <170298971817.1693084.5322289823597780314.stgit@ebuild> In-Reply-To: <170298960827.1693084.7524216970225185214.stgit@ebuild> References: <170298960827.1693084.7524216970225185214.stgit@ebuild> User-Agent: StGit/1.5 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: david.marchand@redhat.com, i.maximets@ovn.org Subject: [ovs-dev] [PATCH v5 04/12] ci: Exclude tests that show random failures through GitHub actions. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" I ran 80 series of full tests, and the following tests showed failures: 802.1ad - vlan_limit +2023-11-20T10:32:11.245Z|00001|dpif_netdev(revalidator5)|ERR|internal error parsing flow key recirc_id(0),dp_hash(0),skb_priority(0), in_port(2),skb_mark(0),ct_state(0),ct_zone(0),ct_mark(0),ct_label(0), packet_type(ns=0,id=0),eth(src=42:7e:4b:46:68:1b,dst=33:33:ff:46:68:1b), eth_type(0x88a8),vlan(vid=4094,pcp=0),encap(eth_type(0x8100), vlan(vid=100,pcp=0),encap(eth_type(0x86dd),ipv6( src=::,dst=ff02::1:ff46:681b,label=0,proto=58,tclass=0,hlimit=255, frag=no),icmpv6(type=135,code=0),nd(target=fe80::407e:4bff:fe46:681b, sll=00:00:00:00:00:00,tll=00:00:00:00:00:00))) +2023-11-20T10:32:11.245Z|00002|dpif(revalidator5)|WARN|netdev@ovs-netdev: failed to put[modify] (Invalid argument) ufid:ef1ca90c-dbd0-4ca7-9869-411bdffd1ece recirc_id(0),dp_hash(0/0), skb_priority(0/0),in_port(2),skb_mark(0/0),ct_state(0/0),ct_zone(0/0), ct_mark(0/0),ct_label(0/0),packet_type(ns=0,id=0), eth(src=42:7e:4b:46:68:1b,dst=33:33:ff:46:68:1b),eth_type(0x88a8), vlan(vid=4094,pcp=0/0x0),encap(eth_type(0x8100), vlan(vid=100/0x0,pcp=0/0x0),encap(eth_type(0x86dd), ipv6(src=::/::,dst=ff02::1:ff46:681b/::,label=0/0,proto=58/0, tclass=0/0,hlimit=255/0,frag=no),icmpv6(type=135/0,code=0/0), nd(target=fe80::407e:4bff:fe46:681b/::, sll=00:00:00:00:00:00/00:00:00:00:00:00, tll=00:00:00:00:00:00/00:00:00:00:00:00))), actions:drop conntrack - zones from other field, more tests +2023-11-20T10:45:43.015Z|00001|dpif(handler5)|WARN|system@ovs-system: execute ct(commit),3 failed (Invalid argument) on packet tcp, vlan_tci=0x0000,dl_src=42:7e:4b:46:68:1b,dl_dst=ba:72:4c:a5:31:6b, nw_src=10.1.1.1,nw_dst=10.1.1.2,nw_tos=0,nw_ecn=0,nw_ttl=64, nw_frag=no,tp_src=53738,tp_dst=80,tcp_flags=psh|ack tcp_csum:e4a conntrack - limit by zone ./system-traffic.at:5154: ovs-appctl dpctl/ct-get-limits zone=0,1,2,3,4,5 --- - 2023-11-20 10:51:09.965375141 +0000 +++ /home/runner/work/ovs/ovs/tests/system-kmod-testsuite.dir/at-groups/ 114/stdout 2023-11-20 10:51:09.956723756 +0000 @@ -1,5 +1,5 @@ default limit=10 -zone=0,limit=5,count=5 +zone=0,limit=5,count=6 As I do not see those failures when running these stand alone on the same Ubuntu distribution, I've disabled them. This patch also adds the 'CHECK_GITHUB_ACTION' macro to skip tests that won't execute successfully through GitHub actions. We could not use the -k !keyword option, as it can not be combined with a range of tests. Signed-off-by: Eelco Chaudron Reviewed-by: Simon Horman --- tests/system-common-macros.at | 4 ++++ tests/system-traffic.at | 3 +++ 2 files changed, 7 insertions(+) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at index 0113aae8b..0620be0c7 100644 --- a/tests/system-common-macros.at +++ b/tests/system-common-macros.at @@ -365,3 +365,7 @@ m4_define([OVS_CHECK_IPROUTE_ENCAP], # OVS_CHECK_CT_CLEAR() m4_define([OVS_CHECK_CT_CLEAR], [AT_SKIP_IF([! grep -q "Datapath supports ct_clear action" ovs-vswitchd.log])]) + +# OVS_CHECK_GITHUB_ACTION +m4_define([OVS_CHECK_GITHUB_ACTION], + [AT_SKIP_IF([test "$GITHUB_ACTIONS" = "true"])]) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 0d6f8cf21..09308ac6b 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -3311,6 +3311,7 @@ AT_CLEANUP AT_SETUP([conntrack - zones from other field, more tests]) CHECK_CONNTRACK() +OVS_CHECK_GITHUB_ACTION() OVS_TRAFFIC_VSWITCHD_START() ADD_NAMESPACES(at_ns0, at_ns1) @@ -5270,6 +5271,7 @@ AT_CLEANUP AT_SETUP([conntrack - limit by zone]) CHECK_CONNTRACK() +OVS_CHECK_GITHUB_ACTION() OVS_TRAFFIC_VSWITCHD_START() ADD_NAMESPACES(at_ns0, at_ns1) @@ -8099,6 +8101,7 @@ AT_CLEANUP AT_BANNER([802.1ad]) AT_SETUP([802.1ad - vlan_limit]) +OVS_CHECK_GITHUB_ACTION() OVS_TRAFFIC_VSWITCHD_START([set Open_vSwitch . other_config:vlan-limit=0]) OVS_CHECK_8021AD()