| Message ID | 166238322871.2220027.12264798646121303771.stgit@ebuild |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tests: Add system-traffic.at tests to check-offloads. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On 05/09/2022 16:07, Eelco Chaudron wrote: > When the test description is part of the OVS_TEST_SKIP_LIST > variable, the test is skipped. > > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> > --- > tests/ofproto-macros.at | 5 ++++- > tests/ovs-macros.at | 7 +++++++ > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at > index 676d55aa9..5c033f771 100644 > --- a/tests/ofproto-macros.at > +++ b/tests/ofproto-macros.at > @@ -161,7 +161,10 @@ m4_define([TESTABLE_LOG], [-vPATTERN:ANY:'%c|%p|%m']) > # before starting ovs-vswitchd. > # > m4_define([_OVS_VSWITCHD_START], > - [dnl Create database. > + [dnl Check if test needs to be run. > + OVS_SKIP_TEST_IF_REQUESTED() > + > + dnl Create database. > touch .conf.db.~lock~ > AT_CHECK([ovsdb-tool create conf.db $abs_top_srcdir/vswitchd/vswitch.ovsschema]) > > diff --git a/tests/ovs-macros.at b/tests/ovs-macros.at > index ebb75ef83..1333c6fc2 100644 > --- a/tests/ovs-macros.at > +++ b/tests/ovs-macros.at > @@ -362,3 +362,10 @@ dnl Add a rule to always accept the traffic. > m4_define([IPTABLES_ACCEPT], > [AT_CHECK([iptables -I INPUT 1 -i $1 -j ACCEPT]) > on_exit 'iptables -D INPUT 1 -i $1']) > + > +# OVS_TEST_SKIP_LIST() > +m4_define([OVS_TEST_SKIP_LIST], [ echo ""]) > + > +# OVS_SKIP_TEST_IF_REQUESTED() > +m4_define([OVS_SKIP_TEST_IF_REQUESTED], > + [AT_SKIP_IF([OVS_TEST_SKIP_LIST() | grep -qx "$at_desc"])]) > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev Hi Just noticed this series but didn't see it got any review. so reviewing Acked-by: Roi Dayan <roid@nvidia.com> Thanks, Roi
diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index 676d55aa9..5c033f771 100644 --- a/tests/ofproto-macros.at +++ b/tests/ofproto-macros.at @@ -161,7 +161,10 @@ m4_define([TESTABLE_LOG], [-vPATTERN:ANY:'%c|%p|%m']) # before starting ovs-vswitchd. # m4_define([_OVS_VSWITCHD_START], - [dnl Create database. + [dnl Check if test needs to be run. + OVS_SKIP_TEST_IF_REQUESTED() + + dnl Create database. touch .conf.db.~lock~ AT_CHECK([ovsdb-tool create conf.db $abs_top_srcdir/vswitchd/vswitch.ovsschema]) diff --git a/tests/ovs-macros.at b/tests/ovs-macros.at index ebb75ef83..1333c6fc2 100644 --- a/tests/ovs-macros.at +++ b/tests/ovs-macros.at @@ -362,3 +362,10 @@ dnl Add a rule to always accept the traffic. m4_define([IPTABLES_ACCEPT], [AT_CHECK([iptables -I INPUT 1 -i $1 -j ACCEPT]) on_exit 'iptables -D INPUT 1 -i $1']) + +# OVS_TEST_SKIP_LIST() +m4_define([OVS_TEST_SKIP_LIST], [ echo ""]) + +# OVS_SKIP_TEST_IF_REQUESTED() +m4_define([OVS_SKIP_TEST_IF_REQUESTED], + [AT_SKIP_IF([OVS_TEST_SKIP_LIST() | grep -qx "$at_desc"])])
When the test description is part of the OVS_TEST_SKIP_LIST variable, the test is skipped. Signed-off-by: Eelco Chaudron <echaudro@redhat.com> --- tests/ofproto-macros.at | 5 ++++- tests/ovs-macros.at | 7 +++++++ 2 files changed, 11 insertions(+), 1 deletion(-)