From patchwork Thu Aug 6 17:18:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Stokes, Ian" X-Patchwork-Id: 1341831 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=intel.com Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BMwFQ1lSXz9sSG for ; Fri, 7 Aug 2020 03:18:49 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id A08F886F51; Thu, 6 Aug 2020 17:18:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qsRynbYcgemF; Thu, 6 Aug 2020 17:18:46 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id B5F3986D8D; Thu, 6 Aug 2020 17:18:46 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 82A4FC0050; Thu, 6 Aug 2020 17:18:46 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7CC29C004C for ; Thu, 6 Aug 2020 17:18:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 64C8188446 for ; Thu, 6 Aug 2020 17:18:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mgX5y8q6plpR for ; Thu, 6 Aug 2020 17:18:42 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by hemlock.osuosl.org (Postfix) with ESMTPS id 8E6C988359 for ; Thu, 6 Aug 2020 17:18:42 +0000 (UTC) IronPort-SDR: HofO8BQUMZ8SJnXI/GiUF3mCkjxNFv2dJu8DUwGtu6ulk28422xIOx7VaAzjDV+H9JBKM9gQVM 6+kRXYujzLvw== X-IronPort-AV: E=McAfee;i="6000,8403,9705"; a="132427110" X-IronPort-AV: E=Sophos;i="5.75,441,1589266800"; d="scan'208";a="132427110" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2020 10:18:41 -0700 IronPort-SDR: yjGr6ZUWFxh2+9RyXgB8etuTNQNZvY6kpcESR7TTUbd58K4UPPT8AFHrxPtAcsA3cp8xbD1kHU lXu+7EaR5I/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,441,1589266800"; d="scan'208";a="437614880" Received: from sivswdev08.ir.intel.com (HELO localhost.localdomain) ([10.237.217.47]) by orsmga004.jf.intel.com with ESMTP; 06 Aug 2020 10:18:39 -0700 From: Ian Stokes To: dev@openvswitch.org Date: Thu, 6 Aug 2020 18:18:37 +0100 Message-Id: <1596734317-13598-1-git-send-email-ian.stokes@intel.com> X-Mailer: git-send-email 1.7.0.7 Cc: maxime.coquelin@redhat.com, i.maximets@ovn.org Subject: [ovs-dev] [PATCH 1/1] dpdk: Deprecate vhost-user dequeue zero-copy. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Dequeue zero-copy is no longer supported for vhost-user client mode in DPDK due to commit [1]. In addition to this, zero-copy mode has been proposed to be marked deprecated in [2] with removal in the next DPDK LTS release. This commit deprecates support for vhost-user dequeue zero-copy in OVS with its removal expected in the next OVS release. [1] 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode") [2] http://mails.dpdk.org/archives/dev/2020-August/177236.html Signed-off-by: Ian Stokes Acked-by: Maxime Coquelin Acked-by: Ilya Maximets Acked-by: Flavio Leitner --- Documentation/topics/dpdk/vhost-user.rst | 5 +++++ NEWS | 2 ++ lib/netdev-dpdk.c | 2 ++ 3 files changed, 9 insertions(+) diff --git a/Documentation/topics/dpdk/vhost-user.rst b/Documentation/topics/dpdk/vhost-user.rst index b1eb5d9da..4af738d11 100644 --- a/Documentation/topics/dpdk/vhost-user.rst +++ b/Documentation/topics/dpdk/vhost-user.rst @@ -556,6 +556,11 @@ shown with:: vhost-user Dequeue Zero Copy (experimental) ------------------------------------------- +.. warning:: + + vhost-user Dequeue Zero Copy is deprecated in OVS and will be removed in + the next release. + Normally when dequeuing a packet from a vHost User device, a memcpy operation must be used to copy that packet from guest address space to host address space. This memcpy can be removed by enabling dequeue zero-copy like so:: diff --git a/NEWS b/NEWS index dceda95a3..5d6489f26 100644 --- a/NEWS +++ b/NEWS @@ -22,6 +22,8 @@ v2.14.0 - xx xxx xxxx CVE-2020-10726, this DPDK version is strongly recommended to be used. * New 'ovs-appctl dpdk/log-list' and 'ovs-appctl dpdk/log-set' commands to list and change log levels in DPDK components. + * Vhost-user Dequeue zero-copy support is deprecated and will be removed + in the next release. - Linux datapath: * Support for kernel versions up to 5.5.x. - AF_XDP: diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 44ebf96da..27bf3b6ed 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -5079,6 +5079,8 @@ netdev_dpdk_vhost_client_reconfigure(struct netdev *netdev) dev->up.name, dev->vhost_id); if (zc_enabled) { VLOG_INFO("Zero copy enabled for vHost port %s", dev->up.name); + VLOG_WARN("Zero copy support is deprecated and will be " + "removed in the next OVS release."); } }