diff mbox series

[ovs-dev] rhel: Fix syntax error when matching version.

Message ID 1592841522-13556-1-git-send-email-u9012063@gmail.com
State New
Headers show
Series [ovs-dev] rhel: Fix syntax error when matching version. | expand

Commit Message

William Tu June 22, 2020, 3:58 p.m. UTC
Remove the extra 'fi' in the script.

VMware-BZ: #2582834
Fixed: fecb28051b35 ("rhel: Support RHEL 7.8 kernel module rpm build.")
Reported-by: Abhijeet Malawade <amalawade@vmware.com>
Signed-off-by: William Tu <u9012063@gmail.com>
---
 rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh | 1 -
 1 file changed, 1 deletion(-)

Comments

Gregory Rose June 22, 2020, 4:09 p.m. UTC | #1
On 6/22/2020 8:58 AM, William Tu wrote:
> Remove the extra 'fi' in the script.
> 
> VMware-BZ: #2582834
> Fixed: fecb28051b35 ("rhel: Support RHEL 7.8 kernel module rpm build.")
> Reported-by: Abhijeet Malawade <amalawade@vmware.com>
> Signed-off-by: William Tu <u9012063@gmail.com>
> ---
>   rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh b/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh
> index 93d487101253..c70e135cd5ef 100644
> --- a/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh
> +++ b/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh
> @@ -113,7 +113,6 @@ if [ "$mainline_major" = "3" ] && [ "$mainline_minor" = "10" ]; then
>           comp_ver=10
>           ver_offset=4
>           installed_ver="$minor_rev"
> -    fi
>       elif [ "$major_rev" = "1127" ]; then
>   #        echo "rhel78"
>           comp_ver=10
> 

Acked-by: Greg Rose <gvrose8192@gmail.com>
William Tu June 22, 2020, 6:44 p.m. UTC | #2
On Mon, Jun 22, 2020 at 9:09 AM Gregory Rose <gvrose8192@gmail.com> wrote:
>
>
>
> On 6/22/2020 8:58 AM, William Tu wrote:
> > Remove the extra 'fi' in the script.
> >
> > VMware-BZ: #2582834
> > Fixed: fecb28051b35 ("rhel: Support RHEL 7.8 kernel module rpm build.")
> > Reported-by: Abhijeet Malawade <amalawade@vmware.com>
> > Signed-off-by: William Tu <u9012063@gmail.com>
> > ---
> >   rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh b/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh
> > index 93d487101253..c70e135cd5ef 100644
> > --- a/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh
> > +++ b/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh
> > @@ -113,7 +113,6 @@ if [ "$mainline_major" = "3" ] && [ "$mainline_minor" = "10" ]; then
> >           comp_ver=10
> >           ver_offset=4
> >           installed_ver="$minor_rev"
> > -    fi
> >       elif [ "$major_rev" = "1127" ]; then
> >   #        echo "rhel78"
> >           comp_ver=10
> >
>
> Acked-by: Greg Rose <gvrose8192@gmail.com>

Thanks.
I applied to master and 2.13.
William
diff mbox series

Patch

diff --git a/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh b/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh
index 93d487101253..c70e135cd5ef 100644
--- a/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh
+++ b/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh
@@ -113,7 +113,6 @@  if [ "$mainline_major" = "3" ] && [ "$mainline_minor" = "10" ]; then
         comp_ver=10
         ver_offset=4
         installed_ver="$minor_rev"
-    fi
     elif [ "$major_rev" = "1127" ]; then
 #        echo "rhel78"
         comp_ver=10