| Message ID | 1589464963-67175-1-git-send-email-u9012063@gmail.com |
|---|---|
| State | Accepted |
| Commit | c6e9348ed488ea88d8945b96d35433093d2b835a |
| Headers | show |
| Series | [ovs-dev] ovs-bugtool: Add -m option to dump-flows. | expand |
On 5/14/2020 7:02 AM, William Tu wrote: > This patch adds 'ovs-appctl dpctl/dump-flows -m' to bugtool, > the output will include wildcarded fields and the miniflow bits, > such as 'dp-extra-info:miniflow_bits(4,1)'. > > Cc: Emma Finn <emma.finn@intel.com> > Signed-off-by: William Tu <u9012063@gmail.com> > --- > utilities/bugtool/plugins/network-status/openvswitch.xml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/utilities/bugtool/plugins/network-status/openvswitch.xml b/utilities/bugtool/plugins/network-status/openvswitch.xml > index e6fa4fd15fff..56e091feb45f 100644 > --- a/utilities/bugtool/plugins/network-status/openvswitch.xml > +++ b/utilities/bugtool/plugins/network-status/openvswitch.xml > @@ -32,6 +32,7 @@ > <command label="ovs-appctl-dpif" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-ovs-appctl-dpif</command> > <command label="ovs-appctl-list-dbs" filters="ovs">ovs-appctl -t ovsdb-server ovsdb-server/list-dbs</command> > <command label="ovs-appctl-dpctl-dump-flows-netdev" filters="ovs" repeat="2">ovs-appctl dpctl/dump-flows netdev@ovs-netdev</command> > + <command label="ovs-appctl-dpctl-dump-flows-netdev-m" filters="ovs" repeat="2">ovs-appctl dpctl/dump-flows -m netdev@ovs-netdev</command> > <command label="ovs-appctl-dpctl-dump-flows-system" filters="ovs" repeat="2">ovs-appctl dpctl/dump-flows system@ovs-system</command> > <command label="ovs-appctl-dpctl-show-s" filters="ovs" repeat="2">ovs-appctl dpctl/show -s</command> > <command label="ovs-ofctl-show" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-ovs-ofctl-loop-over-bridges "show"</command> > Seems fine to me. Acked-by: Greg Rose <gvrose8192@gmail.com>
On Tue, May 19, 2020 at 09:33:05AM -0700, Gregory Rose wrote: > > On 5/14/2020 7:02 AM, William Tu wrote: > >This patch adds 'ovs-appctl dpctl/dump-flows -m' to bugtool, > >the output will include wildcarded fields and the miniflow bits, > >such as 'dp-extra-info:miniflow_bits(4,1)'. > > > >Cc: Emma Finn <emma.finn@intel.com> > >Signed-off-by: William Tu <u9012063@gmail.com> > >--- > > utilities/bugtool/plugins/network-status/openvswitch.xml | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/utilities/bugtool/plugins/network-status/openvswitch.xml b/utilities/bugtool/plugins/network-status/openvswitch.xml > >index e6fa4fd15fff..56e091feb45f 100644 > >--- a/utilities/bugtool/plugins/network-status/openvswitch.xml > >+++ b/utilities/bugtool/plugins/network-status/openvswitch.xml > >@@ -32,6 +32,7 @@ > > <command label="ovs-appctl-dpif" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-ovs-appctl-dpif</command> > > <command label="ovs-appctl-list-dbs" filters="ovs">ovs-appctl -t ovsdb-server ovsdb-server/list-dbs</command> > > <command label="ovs-appctl-dpctl-dump-flows-netdev" filters="ovs" repeat="2">ovs-appctl dpctl/dump-flows netdev@ovs-netdev</command> > >+ <command label="ovs-appctl-dpctl-dump-flows-netdev-m" filters="ovs" repeat="2">ovs-appctl dpctl/dump-flows -m netdev@ovs-netdev</command> > > <command label="ovs-appctl-dpctl-dump-flows-system" filters="ovs" repeat="2">ovs-appctl dpctl/dump-flows system@ovs-system</command> > > <command label="ovs-appctl-dpctl-show-s" filters="ovs" repeat="2">ovs-appctl dpctl/show -s</command> > > <command label="ovs-ofctl-show" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-ovs-ofctl-loop-over-bridges "show"</command> > > > > Seems fine to me. > > Acked-by: Greg Rose <gvrose8192@gmail.com> Applied to master, thanks. William
diff --git a/utilities/bugtool/plugins/network-status/openvswitch.xml b/utilities/bugtool/plugins/network-status/openvswitch.xml index e6fa4fd15fff..56e091feb45f 100644 --- a/utilities/bugtool/plugins/network-status/openvswitch.xml +++ b/utilities/bugtool/plugins/network-status/openvswitch.xml @@ -32,6 +32,7 @@ <command label="ovs-appctl-dpif" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-ovs-appctl-dpif</command> <command label="ovs-appctl-list-dbs" filters="ovs">ovs-appctl -t ovsdb-server ovsdb-server/list-dbs</command> <command label="ovs-appctl-dpctl-dump-flows-netdev" filters="ovs" repeat="2">ovs-appctl dpctl/dump-flows netdev@ovs-netdev</command> + <command label="ovs-appctl-dpctl-dump-flows-netdev-m" filters="ovs" repeat="2">ovs-appctl dpctl/dump-flows -m netdev@ovs-netdev</command> <command label="ovs-appctl-dpctl-dump-flows-system" filters="ovs" repeat="2">ovs-appctl dpctl/dump-flows system@ovs-system</command> <command label="ovs-appctl-dpctl-show-s" filters="ovs" repeat="2">ovs-appctl dpctl/show -s</command> <command label="ovs-ofctl-show" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-ovs-ofctl-loop-over-bridges "show"</command>
This patch adds 'ovs-appctl dpctl/dump-flows -m' to bugtool, the output will include wildcarded fields and the miniflow bits, such as 'dp-extra-info:miniflow_bits(4,1)'. Cc: Emma Finn <emma.finn@intel.com> Signed-off-by: William Tu <u9012063@gmail.com> --- utilities/bugtool/plugins/network-status/openvswitch.xml | 1 + 1 file changed, 1 insertion(+)