| Message ID | 1589296951-75730-2-git-send-email-u9012063@gmail.com |
|---|---|
| State | Accepted |
| Commit | fae687c85ef56d5d3d680aa23587fcc083ddeb7f |
| Headers | show |
| Series | [ovs-dev,1/2] oss-fuzz: Fix fuzzer flags in CFLAGS. | expand |
LGTM, thanks. Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com> On Tue, May 12, 2020 at 8:23 AM William Tu <u9012063@gmail.com> wrote: > Clang reports: > tests/oss-fuzz/miniflow_target.c:209:26: error: suggest braces around \ > initialization of subobject > [-Werror,-Wmissing-braces] > struct flow flow2 = {0}; > > Fix it by using memset. > > Cc: Bhargava Shastry <bshastry@sect.tu-berlin.de> > Cc: Yifeng Sun <pkusunyifeng@gmail.com> > Signed-off-by: William Tu <u9012063@gmail.com> > --- > tests/oss-fuzz/miniflow_target.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/oss-fuzz/miniflow_target.c > b/tests/oss-fuzz/miniflow_target.c > index 393443061e85..50b8b0e64237 100644 > --- a/tests/oss-fuzz/miniflow_target.c > +++ b/tests/oss-fuzz/miniflow_target.c > @@ -206,8 +206,9 @@ test_minimask_combine(struct flow *flow) > struct minimask minicombined; > uint64_t storage[FLOW_U64S]; > } m; > - struct flow flow2 = {0}; > + struct flow flow2; > > + memset(&flow2, 0, sizeof flow2); > mask.masks = *flow; > minimask = minimask_create(&mask); > > -- > 2.7.4 > >
On Tue, May 12, 2020 at 04:31:58PM -0700, Yifeng Sun wrote: > LGTM, thanks. > > Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com> > > Applied, thanks. William
diff --git a/tests/oss-fuzz/miniflow_target.c b/tests/oss-fuzz/miniflow_target.c index 393443061e85..50b8b0e64237 100644 --- a/tests/oss-fuzz/miniflow_target.c +++ b/tests/oss-fuzz/miniflow_target.c @@ -206,8 +206,9 @@ test_minimask_combine(struct flow *flow) struct minimask minicombined; uint64_t storage[FLOW_U64S]; } m; - struct flow flow2 = {0}; + struct flow flow2; + memset(&flow2, 0, sizeof flow2); mask.masks = *flow; minimask = minimask_create(&mask);
Clang reports: tests/oss-fuzz/miniflow_target.c:209:26: error: suggest braces around \ initialization of subobject [-Werror,-Wmissing-braces] struct flow flow2 = {0}; Fix it by using memset. Cc: Bhargava Shastry <bshastry@sect.tu-berlin.de> Cc: Yifeng Sun <pkusunyifeng@gmail.com> Signed-off-by: William Tu <u9012063@gmail.com> --- tests/oss-fuzz/miniflow_target.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)