From patchwork Mon May 4 16:28:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1282804 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=XtMhJjZS; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49G7bh6TTPz9sSd for ; Tue, 5 May 2020 02:29:20 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 09349876CB; Mon, 4 May 2020 16:29:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HvBzurfMqy0M; Mon, 4 May 2020 16:29:18 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 74E7F87446; Mon, 4 May 2020 16:29:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 56DB5C0175; Mon, 4 May 2020 16:29:18 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 828C5C088C for ; Mon, 4 May 2020 16:29:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 7C39C88AD8 for ; Mon, 4 May 2020 16:29:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U2pKewE1uVHL for ; Mon, 4 May 2020 16:29:16 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by hemlock.osuosl.org (Postfix) with ESMTPS id 09DB688C7F for ; Mon, 4 May 2020 16:29:16 +0000 (UTC) Received: by mail-pl1-f196.google.com with SMTP id x6so2277921plv.8 for ; Mon, 04 May 2020 09:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=mTgvUT7tw7bPqP0lRpMu7E6MQOZ7Ijy/PcAb1vb/wWs=; b=XtMhJjZSUmU61GfdlX+m4mkTg6fsaPczmrRuoX1/UB+pyeE0wWq+CNihAEPYXIGbEg AQy1FfQX4wAixwJDdtcZUtq5WPnZpqOTi8qeOert4zyE8QzV356imz8kZAoOAMWZ2vmz qdsrdwjE42+Jl5GCPjDSTLV+dIiLM01mlWPmKrGBsJwMKU/VWgKi6qD3YcSLVsf124SS O3SEpYI0fWkAnyUUZkRtsBBuzesyTyn4nNj1Ebf/GrkpfO8TFSrfbgtQJ7jSBv7yFw6z TPzYc7OSDFhORd3qj0goLWIOCdNTZfXfYqGszV5XvU4cwCrSdv9o+jAulYvE7Vqv0es4 /N9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=mTgvUT7tw7bPqP0lRpMu7E6MQOZ7Ijy/PcAb1vb/wWs=; b=LI1hvgFta0ihSobbKDiXYJYTJZSA6PyRviaosUkLAS13lh9GaNngNUdTMTlJq51c0E XRyvbm6TrU4IhaXi2Ml0mevdvDivJiksjTyvJ+2W3QkEzKWoEhlapzBkbrW1Y6bDFAwX tOGndtc59BPJqFePgbz4/w/sTv67ZWgWXLncVW0oVL088xUHgngEpENEPrd5uNiDD25R BAovd7BQtTgGRqLS6xDSvT8N9JCKp4ybgDiIza8Y5BaFhK9LYcBfAKuwUDPWVxKxBEb2 p2pXOjA7RVkSQWMFtV7oIbkQCOruM/PTlt4o1/Q06H2BhU8de13L4nWNAOklnx8Q63bw W5aQ== X-Gm-Message-State: AGi0PuZNZ8aRP5FuCnaGzabWIKwKG8/H2xVQyXQSYUnf8RzfdiZWjOPF sJHB8uCILCe7GMzX9ZH+i+RkGFwv X-Google-Smtp-Source: APiQypJvCdhW+08K8sxjn4h30LMfnT1cp7x6fuNJ6T7qS8hhf6yat7Nyo6yUnkvcrpDv92ZLqupzzA== X-Received: by 2002:a17:90b:93:: with SMTP id bb19mr155912pjb.134.1588609755311; Mon, 04 May 2020 09:29:15 -0700 (PDT) Received: from sc9-mailhost2.vmware.com (c-76-21-95-192.hsd1.ca.comcast.net. [76.21.95.192]) by smtp.gmail.com with ESMTPSA id g184sm9320512pfb.80.2020.05.04.09.29.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 May 2020 09:29:14 -0700 (PDT) From: William Tu To: dev@openvswitch.org Date: Mon, 4 May 2020 09:28:51 -0700 Message-Id: <1588609731-64817-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 Subject: [ovs-dev] [PATCH] netdev-afxdp: Fix missing init. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" When introducing the interrupt mode for netdev-afxdp, the netdev init function is accidentally removed. Fix it by adding it back. Fixes: 5bfc519fee499 ("netdev-afxdp: Add interrupt mode netdev class.") Signed-off-by: William Tu Acked-by: Greg Rose Acked-by: Ilya Maximets --- lib/netdev-linux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 40d0cc1105ea..b52071e92ec7 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -3588,6 +3588,7 @@ const struct netdev_class netdev_internal_class = { #ifdef HAVE_AF_XDP #define NETDEV_AFXDP_CLASS_COMMON \ + .init = netdev_afxdp_init, \ .construct = netdev_afxdp_construct, \ .destruct = netdev_afxdp_destruct, \ .get_stats = netdev_afxdp_get_stats, \