| Message ID | 1588609731-64817-1-git-send-email-u9012063@gmail.com |
|---|---|
| State | Accepted |
| Commit | 5119cfe32d021300663809eb23be6b33cbd4073a |
| Headers | show |
| Series | [ovs-dev] netdev-afxdp: Fix missing init. | expand |
On 5/4/2020 9:28 AM, William Tu wrote: > When introducing the interrupt mode for netdev-afxdp, the netdev > init function is accidentally removed. Fix it by adding it back. > > Fixes: 5bfc519fee499 ("netdev-afxdp: Add interrupt mode netdev class.") > Signed-off-by: William Tu <u9012063@gmail.com> > --- > lib/netdev-linux.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c > index 40d0cc1105ea..b52071e92ec7 100644 > --- a/lib/netdev-linux.c > +++ b/lib/netdev-linux.c > @@ -3588,6 +3588,7 @@ const struct netdev_class netdev_internal_class = { > > #ifdef HAVE_AF_XDP > #define NETDEV_AFXDP_CLASS_COMMON \ > + .init = netdev_afxdp_init, \ > .construct = netdev_afxdp_construct, \ > .destruct = netdev_afxdp_destruct, \ > .get_stats = netdev_afxdp_get_stats, \ > Acked-by: Greg Rose <gvrose8192@gmail.com>
On 5/4/20 6:28 PM, William Tu wrote: > When introducing the interrupt mode for netdev-afxdp, the netdev > init function is accidentally removed. Fix it by adding it back. > > Fixes: 5bfc519fee499 ("netdev-afxdp: Add interrupt mode netdev class.") > Signed-off-by: William Tu <u9012063@gmail.com> > --- > lib/netdev-linux.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c > index 40d0cc1105ea..b52071e92ec7 100644 > --- a/lib/netdev-linux.c > +++ b/lib/netdev-linux.c > @@ -3588,6 +3588,7 @@ const struct netdev_class netdev_internal_class = { > > #ifdef HAVE_AF_XDP > #define NETDEV_AFXDP_CLASS_COMMON \ > + .init = netdev_afxdp_init, \ > .construct = netdev_afxdp_construct, \ > .destruct = netdev_afxdp_destruct, \ > .get_stats = netdev_afxdp_get_stats, \ > Oops. Acked-by: Ilya Maximets <i.maximets@ovn.org>
On Mon, May 04, 2020 at 10:58:06AM -0700, Gregory Rose wrote: > > On 5/4/2020 9:28 AM, William Tu wrote: > >When introducing the interrupt mode for netdev-afxdp, the netdev > >init function is accidentally removed. Fix it by adding it back. > > > >Fixes: 5bfc519fee499 ("netdev-afxdp: Add interrupt mode netdev class.") > >Signed-off-by: William Tu <u9012063@gmail.com> > >--- > > lib/netdev-linux.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c > >index 40d0cc1105ea..b52071e92ec7 100644 > >--- a/lib/netdev-linux.c > >+++ b/lib/netdev-linux.c > >@@ -3588,6 +3588,7 @@ const struct netdev_class netdev_internal_class = { > > #ifdef HAVE_AF_XDP > > #define NETDEV_AFXDP_CLASS_COMMON \ > >+ .init = netdev_afxdp_init, \ > > .construct = netdev_afxdp_construct, \ > > .destruct = netdev_afxdp_destruct, \ > > .get_stats = netdev_afxdp_get_stats, \ > > > > Acked-by: Greg Rose <gvrose8192@gmail.com> Applied to master, thanks
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 40d0cc1105ea..b52071e92ec7 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -3588,6 +3588,7 @@ const struct netdev_class netdev_internal_class = { #ifdef HAVE_AF_XDP #define NETDEV_AFXDP_CLASS_COMMON \ + .init = netdev_afxdp_init, \ .construct = netdev_afxdp_construct, \ .destruct = netdev_afxdp_destruct, \ .get_stats = netdev_afxdp_get_stats, \
When introducing the interrupt mode for netdev-afxdp, the netdev init function is accidentally removed. Fix it by adding it back. Fixes: 5bfc519fee499 ("netdev-afxdp: Add interrupt mode netdev class.") Signed-off-by: William Tu <u9012063@gmail.com> --- lib/netdev-linux.c | 1 + 1 file changed, 1 insertion(+)