| Message ID | 1586792601-78270-1-git-send-email-u9012063@gmail.com |
|---|---|
| State | Accepted |
| Commit | fce16ca1dd308a2c1987b1c5f0f5800ddb6e891b |
| Headers | show |
| Series | [ovs-dev] ofp-actions: Fix memory leak on error path. | expand |
Looks good to me, thanks. Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com> On Mon, Apr 13, 2020 at 8:43 AM William Tu <u9012063@gmail.com> wrote: > Need to free the memory before return. Detected by gcc10. > > Signed-off-by: William Tu <u9012063@gmail.com> > --- > lib/ofp-actions.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c > index ef8b2b4527f9..a94d1a7ca918 100644 > --- a/lib/ofp-actions.c > +++ b/lib/ofp-actions.c > @@ -5966,6 +5966,7 @@ parse_CLONE(char *arg, const struct > ofpact_parse_params *pp) > clone = pp->ofpacts->header; > > if (ofpbuf_oversized(pp->ofpacts)) { > + free(error); > return xasprintf("input too big"); > } > > -- > 2.7.4 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On Mon, Apr 13, 2020 at 9:26 AM Yifeng Sun <pkusunyifeng@gmail.com> wrote: > > Looks good to me, thanks. > > Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com> > Applied to master, thanks
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index ef8b2b4527f9..a94d1a7ca918 100644 --- a/lib/ofp-actions.c +++ b/lib/ofp-actions.c @@ -5966,6 +5966,7 @@ parse_CLONE(char *arg, const struct ofpact_parse_params *pp) clone = pp->ofpacts->header; if (ofpbuf_oversized(pp->ofpacts)) { + free(error); return xasprintf("input too big"); }
Need to free the memory before return. Detected by gcc10. Signed-off-by: William Tu <u9012063@gmail.com> --- lib/ofp-actions.c | 1 + 1 file changed, 1 insertion(+)