| Message ID | 1574105036-28928-1-git-send-email-pkusunyifeng@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [ovs-dev] rhel: Fix ovs-kmod-manage.sh that may create invalid soft links | expand |
On Mon, Nov 18, 2019 at 11:24 AM Yifeng Sun <pkusunyifeng@gmail.com> wrote: > > Current code iterates every kernel under '/lib/modules' for a matched > version. As a result, this script may create invalid soft links if the > matched kernel doesn't have openvswitch-kmod RPM installed. > > This patch fixes it. > > VMWare-BZ: #2257534 > > Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> > --- Thanks Yifeng for the fix. This patch fixes the issue where RHEL has been upgraded, and the script may create weak-update symbolic link to the old kernel's directory. Can you add a fix tag to this patch? Otherwise, this patch looks good to me. Acked-by: Yi-Hung Wei <yihung.wei@gmail.com> Thanks, -Yi-Hung
Will do, thanks! On Mon, Nov 18, 2019 at 11:35 AM Yi-Hung Wei <yihung.wei@gmail.com> wrote: > > On Mon, Nov 18, 2019 at 11:24 AM Yifeng Sun <pkusunyifeng@gmail.com> wrote: > > > > Current code iterates every kernel under '/lib/modules' for a matched > > version. As a result, this script may create invalid soft links if the > > matched kernel doesn't have openvswitch-kmod RPM installed. > > > > This patch fixes it. > > > > VMWare-BZ: #2257534 > > > > Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> > > --- > > Thanks Yifeng for the fix. This patch fixes the issue where RHEL has > been upgraded, and the script may create weak-update symbolic link to > the old kernel's directory. > > Can you add a fix tag to this patch? Otherwise, this patch looks good to me. > > Acked-by: Yi-Hung Wei <yihung.wei@gmail.com> > > Thanks, > > -Yi-Hung
diff --git a/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh b/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh index a643b55ff0f8..a252b391ecba 100644 --- a/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh +++ b/rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh @@ -157,7 +157,7 @@ fi #$kmod_high_ver" found_match=false -for kname in `ls -d /lib/modules/*` +for kname in $kversion; do IFS='.\|-' read -r -a pkg_ver_nums <<<"${kname}" pkg_ver=${pkg_ver_nums[$ver_offset]} @@ -184,14 +184,14 @@ if [ "$found_match" = "false" ]; then exit 1 fi -if [ "$requested_kernel" != "/lib/modules/$current_kernel" ]; then +if [ "$requested_kernel" != "$current_kernel" ]; then if [ ! -d /lib/modules/$current_kernel/weak-updates/openvswitch ]; then mkdir -p /lib/modules/$current_kernel/weak-updates mkdir -p /lib/modules/$current_kernel/weak-updates/openvswitch fi for m in openvswitch vport-gre vport-stt vport-geneve \ vport-lisp vport-vxlan; do - ln -f -s $requested_kernel/extra/openvswitch/$m.ko \ + ln -f -s /lib/modules/$requested_kernel/extra/openvswitch/$m.ko \ /lib/modules/$current_kernel/weak-updates/openvswitch/$m.ko done else
Current code iterates every kernel under '/lib/modules' for a matched version. As a result, this script may create invalid soft links if the matched kernel doesn't have openvswitch-kmod RPM installed. This patch fixes it. VMWare-BZ: #2257534 Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> --- rhel/usr_share_openvswitch_scripts_ovs-kmod-manage.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)