From patchwork Tue Nov 5 23:35:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1190058 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nybYfJTa"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4775dl19f5z9sP6 for ; Wed, 6 Nov 2019 10:36:10 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id D9886DC8; Tue, 5 Nov 2019 23:36:08 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 3D1A0DB2 for ; Tue, 5 Nov 2019 23:36:07 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id E82048A0 for ; Tue, 5 Nov 2019 23:36:06 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id x6so10478941pln.2 for ; Tue, 05 Nov 2019 15:36:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=+dI7MiyBB+iXW8BQ+7ZKzCd+BTMCNqpW0pfsa8pFCAo=; b=nybYfJTawQJBbdoYSmA0BY7OktvgaHtDt/mYS58hsW0N6XIel76UQdFBjzP9TGKg0f 9a60Yz0fHy1ycGVIBXk0BsrkyLw6U9mwHQCsIuzgZz+zYpxXR+qtH98SgqnBD7I3xhfA u0CGs6WhdbwtKvk/KqMQoyT5leJodW6ypm1tavP9XMpE4AxCTqzOr/8R9xhva6Q9X4Ie iD/wdbDJYYfI1Gm0gOvXFrCFjvz6MjJKOtUbDszImsT6gTxJzH04q4F4b6JzBtjg5u31 1PHlQxJi+jyVNPRHPVvp8oN7i7ySuRdPAd/pBAbactut1qqjzxx9Ra964zdyBtecpFK+ OHDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=+dI7MiyBB+iXW8BQ+7ZKzCd+BTMCNqpW0pfsa8pFCAo=; b=Md5z3o/bPFqE36ZZ/mFG8zEJkiOEyBrbAP06dUAyLjs6q/2+UNrfwf9YTKbaBLNU3Q KVep6LnaH7L4wnzF4AWaGkjElTPnPWzQKJ0tZuA2kpEJ7g0GSskUEKU1n0TaXupEvoku rlKHWpd9dcdxbUR22Aa1gV5qGQwF96aP27MJ/cJVaUhHV1QxzCbjs5lybqX57Q6k40hO GFu/fOrZtbIdsbh8H1NR76xem5KI22mXuoyWEt0floEMSwlYmiRJmnx+upfdZlz1p4F6 XtADiTaKB54FF9krAxit8KDO+lCJyI9+XK8XjiSU6FsxWsMGXJtGhuQMT+4VQit+ySgf BKJg== X-Gm-Message-State: APjAAAW/RtC007eOBcf9rntVmTUt49q0gS+/n7UnkP0qBiPuEQ5kyP/9 lM7bHfRieRa5meUXQSHHZPI= X-Google-Smtp-Source: APXvYqzt6M24pj2Xm/yQdLNplmm/0bPjcaqtdKevtytMhCUhgL+deRJ6ATe7eQ+b3by8vWZ8zXJJEw== X-Received: by 2002:a17:902:ba91:: with SMTP id k17mr24528370pls.100.1572996966320; Tue, 05 Nov 2019 15:36:06 -0800 (PST) Received: from sc9-mailhost2.vmware.com ([66.170.99.95]) by smtp.gmail.com with ESMTPSA id q26sm17952175pgk.60.2019.11.05.15.36.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 05 Nov 2019 15:36:05 -0800 (PST) From: William Tu To: netdev@vger.kernel.org Date: Tue, 5 Nov 2019 15:35:38 -0800 Message-Id: <1572996938-23957-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: dev@openvswitch.org, bjorn.topel@intel.com, magnus.karlsson@intel.com, i.maximets@ovn.org Subject: [ovs-dev] [PATCH net-next] xsk: Enable shared umem support. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Currently the shared umem feature is not supported in libbpf. The patch removes the refcount check in libbpf to enable use of shared umem. Also, a umem can be shared by multiple netdevs, so remove the checking at xsk_bind. Tested using OVS at: https://mail.openvswitch.org/pipermail/ovs-dev/2019-November/364392.html Signed-off-by: William Tu --- net/xdp/xsk.c | 5 ----- tools/lib/bpf/xsk.c | 10 +++++----- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c index 6040bc2b0088..0f2b16e275e3 100644 --- a/net/xdp/xsk.c +++ b/net/xdp/xsk.c @@ -697,11 +697,6 @@ static int xsk_bind(struct socket *sock, struct sockaddr *addr, int addr_len) sockfd_put(sock); goto out_unlock; } - if (umem_xs->dev != dev || umem_xs->queue_id != qid) { - err = -EINVAL; - sockfd_put(sock); - goto out_unlock; - } xdp_get_umem(umem_xs->umem); WRITE_ONCE(xs->umem, umem_xs->umem); diff --git a/tools/lib/bpf/xsk.c b/tools/lib/bpf/xsk.c index 74d84f36a5b2..e6c4eb077dcd 100644 --- a/tools/lib/bpf/xsk.c +++ b/tools/lib/bpf/xsk.c @@ -579,16 +579,13 @@ int xsk_socket__create(struct xsk_socket **xsk_ptr, const char *ifname, struct sockaddr_xdp sxdp = {}; struct xdp_mmap_offsets off; struct xsk_socket *xsk; + bool shared; int err; if (!umem || !xsk_ptr || !rx || !tx) return -EFAULT; - if (umem->refcount) { - pr_warn("Error: shared umems not supported by libbpf.\n"); - return -EBUSY; - } - + shared = !!(usr_config->bind_flags & XDP_SHARED_UMEM); xsk = calloc(1, sizeof(*xsk)); if (!xsk) return -ENOMEM; @@ -687,6 +684,9 @@ int xsk_socket__create(struct xsk_socket **xsk_ptr, const char *ifname, sxdp.sxdp_queue_id = xsk->queue_id; sxdp.sxdp_flags = xsk->config.bind_flags; + if (shared) + sxdp.sxdp_shared_umem_fd = umem->fd; + err = bind(xsk->fd, (struct sockaddr *)&sxdp, sizeof(sxdp)); if (err) { err = -errno;