From patchwork Mon Sep 10 18:37:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Louis Peens X-Patchwork-Id: 968179 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netronome.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="gpG4bRrJ"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 428Gxz6nRWz9s4V for ; Tue, 11 Sep 2018 04:37:59 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 4E85ACAF; Mon, 10 Sep 2018 18:37:58 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id B939ECAF for ; Mon, 10 Sep 2018 18:37:56 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 27AC07C7 for ; Mon, 10 Sep 2018 18:37:56 +0000 (UTC) Received: by mail-wr1-f53.google.com with SMTP id a108-v6so22986362wrc.13 for ; Mon, 10 Sep 2018 11:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=p+fAnR8e9SyF7sXEfiqyc2ga0DM+cBm1Pc/hbb+dK2g=; b=gpG4bRrJpx99QgqkA8JvW5j9GUP8YxNy2eguGUi1v4wnqlvWv8uH3zuHpaoR0zHBkO 4Jon4GaY+lDM/SxhEpGbIyynFiW9u5vo27h8Ite/gk+Syb6+WEF66tw6RLE9Lk8trJaB uOttAiiMqsGyHpFPeRJyFf7ZxdEvg+5trGABm3numpZGlwGJdiEQEFL9DI8riIXimAS5 j5TzlL7iC6doaoEUDI4Zc2clCauPogw529e6ok/k+LzH5uaZDYH79YmNGgpv6bmg9tcz CzlJPK/mNNBBYbx1dKLTETd0qxOdN8CDXFPUx0sH0KZB6pzvZ8PFDNOpVvDxoTCalIvA ++QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=p+fAnR8e9SyF7sXEfiqyc2ga0DM+cBm1Pc/hbb+dK2g=; b=jMKz7CZ1L5tgg8Z/WiJguBEev4b6YKP+OiG+Qa8ixQA6zPy31St+yuK5xdGnsoLuT+ sD8t0qVDAeVGeL4ICAUH2BK6HsXjQnRmX0SX31XGU3cgyN/AY+0RzZGDaRiGkwViwkpG xAtRnDsvap6vfV8ANX8lccLTkdyxbPOSx4BXYdLze4W1HuVjIuH5WNIRCU1jpHWGQ7Jt WfBsK1UtcIlLzT6sGnxD9KFJn+VwU/+WKgdHoGeNdIeM2/yIt9m+y0JKTBJyfc55L0Bj OQxaucoPvOTEE224ckwW/4ktTXgipr/aGavHYLK9O/0yqkvQPV9N9wnldPKZctwaeOlU dH/w== X-Gm-Message-State: APzg51C5MRq+Id8tlWoUFf2QfNKpndokgvUtxN0WGdk2WOjNw2RHgihp ZO6mseBu+Ic6cEl8UFXxsYzn8QEQNJfxLA== X-Google-Smtp-Source: ANB0VdbUsaFwpDItwV8N+Heg06C6QaNQoaT849cKGvMpH0Y+7eXutWRx0odv2luz3tRRcFhhBfGwTg== X-Received: by 2002:a5d:4e4c:: with SMTP id r12-v6mr15787989wrt.27.1536604674596; Mon, 10 Sep 2018 11:37:54 -0700 (PDT) Received: from macuntu.za.netronome.com ([105.22.41.74]) by smtp.gmail.com with ESMTPSA id w18-v6sm38175266wrc.38.2018.09.10.11.37.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 10 Sep 2018 11:37:53 -0700 (PDT) From: Louis Peens To: dev@openvswitch.org Date: Mon, 10 Sep 2018 20:37:40 +0200 Message-Id: <1536604660-32030-1-git-send-email-louis.peens@netronome.com> X-Mailer: git-send-email 2.7.4 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: horms+renesas@verge.net.au, Louis Peens Subject: [ovs-dev] [PATCH ovs-2.8] lib/tc: reject offloading of non-Ethernet packets X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org When a packet is marked with the special ethtype of OFP_DL_TYPE_NOT_ETH_TYPE it got wrongly installed into tc datapath as a match on a packet with that ethtype. This prevents that from happening. Signed-off-by: Louis Peens Reviewed-by: Pieter Jansen van Vuuren Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index 8504c93..a694651 100644 --- a/lib/netdev-tc-offloads.c +++ b/lib/netdev-tc-offloads.c @@ -648,6 +648,10 @@ test_key_and_mask(struct match *match) "offloading attribute icmp_code isn't supported"); return EOPNOTSUPP; } + } else if (key->dl_type == htons(OFP_DL_TYPE_NOT_ETH_TYPE)) { + VLOG_DBG_RL(&rl, + "offloading of non-ethernet packets isn't supported"); + return EOPNOTSUPP; } if (is_ip_any(key) && key->nw_proto == IPPROTO_TCP && mask->tcp_flags) { if (mask->tcp_flags) {