| Message ID | 1534862529-12916-2-git-send-email-pkusunyifeng@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev,1/2] porting: Support for kernel 4.16.x & 4.17.x | expand |
On 8/21/2018 7:42 AM, Yifeng Sun wrote: > GRE-related tests are skipped on ubuntu-18.04.1 because the > vanilla `ip` will fail to set dev's mac address. This bug > is described in this link: > > https://bugzilla.redhat.com/show_bug.cgi?id=1550097 > > This patch enables GRE tests to run even if the buggy `ip` > is being used. > > Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> Looks good, thanks! Reviewed-by: Greg Rose <gvrose8192@gmail.com> Tested-by: Greg Rose <gvrose8192@gmail.com> > --- > tests/system-traffic.at | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tests/system-traffic.at b/tests/system-traffic.at > index 3e6d3dd..2a33e9f 100644 > --- a/tests/system-traffic.at > +++ b/tests/system-traffic.at > @@ -576,7 +576,7 @@ OVS_TRAFFIC_VSWITCHD_STOP > AT_CLEANUP > > AT_SETUP([datapath - ping over gre tunnel by simulated packets]) > -OVS_CHECK_KERNEL(3, 10, 4, 15) > +OVS_CHECK_KERNEL(3, 10, 4, 17) > > OVS_TRAFFIC_VSWITCHD_START() > AT_CHECK([ovs-vsctl -- set bridge br0 other-config:hwaddr=\"f2:ff:00:00:00:01\"]) > @@ -626,7 +626,7 @@ OVS_TRAFFIC_VSWITCHD_STOP > AT_CLEANUP > > AT_SETUP([datapath - ping over erspan v1 tunnel by simulated packets]) > -OVS_CHECK_KERNEL(3, 10, 4, 15) > +OVS_CHECK_KERNEL(3, 10, 4, 17) > > OVS_TRAFFIC_VSWITCHD_START() > AT_CHECK([ovs-vsctl -- set bridge br0 other-config:hwaddr=\"f2:ff:00:00:00:01\"]) > @@ -678,7 +678,7 @@ OVS_TRAFFIC_VSWITCHD_STOP > AT_CLEANUP > > AT_SETUP([datapath - ping over erspan v2 tunnel by simulated packets]) > -OVS_CHECK_KERNEL(3, 10, 4, 15) > +OVS_CHECK_KERNEL(3, 10, 4, 17) > > OVS_TRAFFIC_VSWITCHD_START() > AT_CHECK([ovs-vsctl -- set bridge br0 other-config:hwaddr=\"f2:ff:00:00:00:01\"]) > @@ -731,7 +731,7 @@ OVS_TRAFFIC_VSWITCHD_STOP > AT_CLEANUP > > AT_SETUP([datapath - ping over ip6erspan v1 tunnel by simulated packets]) > -OVS_CHECK_KERNEL(3, 10, 4, 15) > +OVS_CHECK_KERNEL(3, 10, 4, 17) > > OVS_TRAFFIC_VSWITCHD_START() > AT_CHECK([ovs-vsctl -- set bridge br0 other-config:hwaddr=\"f2:ff:00:00:00:01\"]) > @@ -786,7 +786,7 @@ OVS_TRAFFIC_VSWITCHD_STOP > AT_CLEANUP > > AT_SETUP([datapath - ping over ip6erspan v2 tunnel by simulated packets]) > -OVS_CHECK_KERNEL(3, 10, 4, 15) > +OVS_CHECK_KERNEL(3, 10, 4, 17) > > OVS_TRAFFIC_VSWITCHD_START() > AT_CHECK([ovs-vsctl -- set bridge br0 other-config:hwaddr=\"f2:ff:00:00:00:01\"])
On Thu, Aug 23, 2018 at 10:18:05PM -0700, Gregory Rose wrote: > On 8/21/2018 7:42 AM, Yifeng Sun wrote: > >GRE-related tests are skipped on ubuntu-18.04.1 because the > >vanilla `ip` will fail to set dev's mac address. This bug > >is described in this link: > > > >https://bugzilla.redhat.com/show_bug.cgi?id=1550097 > > > >This patch enables GRE tests to run even if the buggy `ip` > >is being used. > > > >Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> > > Looks good, thanks! > > Reviewed-by: Greg Rose <gvrose8192@gmail.com> > Tested-by: Greg Rose <gvrose8192@gmail.com> Thanks Yifeng (and Greg). I applied this to master.
diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 3e6d3dd..2a33e9f 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -576,7 +576,7 @@ OVS_TRAFFIC_VSWITCHD_STOP AT_CLEANUP AT_SETUP([datapath - ping over gre tunnel by simulated packets]) -OVS_CHECK_KERNEL(3, 10, 4, 15) +OVS_CHECK_KERNEL(3, 10, 4, 17) OVS_TRAFFIC_VSWITCHD_START() AT_CHECK([ovs-vsctl -- set bridge br0 other-config:hwaddr=\"f2:ff:00:00:00:01\"]) @@ -626,7 +626,7 @@ OVS_TRAFFIC_VSWITCHD_STOP AT_CLEANUP AT_SETUP([datapath - ping over erspan v1 tunnel by simulated packets]) -OVS_CHECK_KERNEL(3, 10, 4, 15) +OVS_CHECK_KERNEL(3, 10, 4, 17) OVS_TRAFFIC_VSWITCHD_START() AT_CHECK([ovs-vsctl -- set bridge br0 other-config:hwaddr=\"f2:ff:00:00:00:01\"]) @@ -678,7 +678,7 @@ OVS_TRAFFIC_VSWITCHD_STOP AT_CLEANUP AT_SETUP([datapath - ping over erspan v2 tunnel by simulated packets]) -OVS_CHECK_KERNEL(3, 10, 4, 15) +OVS_CHECK_KERNEL(3, 10, 4, 17) OVS_TRAFFIC_VSWITCHD_START() AT_CHECK([ovs-vsctl -- set bridge br0 other-config:hwaddr=\"f2:ff:00:00:00:01\"]) @@ -731,7 +731,7 @@ OVS_TRAFFIC_VSWITCHD_STOP AT_CLEANUP AT_SETUP([datapath - ping over ip6erspan v1 tunnel by simulated packets]) -OVS_CHECK_KERNEL(3, 10, 4, 15) +OVS_CHECK_KERNEL(3, 10, 4, 17) OVS_TRAFFIC_VSWITCHD_START() AT_CHECK([ovs-vsctl -- set bridge br0 other-config:hwaddr=\"f2:ff:00:00:00:01\"]) @@ -786,7 +786,7 @@ OVS_TRAFFIC_VSWITCHD_STOP AT_CLEANUP AT_SETUP([datapath - ping over ip6erspan v2 tunnel by simulated packets]) -OVS_CHECK_KERNEL(3, 10, 4, 15) +OVS_CHECK_KERNEL(3, 10, 4, 17) OVS_TRAFFIC_VSWITCHD_START() AT_CHECK([ovs-vsctl -- set bridge br0 other-config:hwaddr=\"f2:ff:00:00:00:01\"])
GRE-related tests are skipped on ubuntu-18.04.1 because the vanilla `ip` will fail to set dev's mac address. This bug is described in this link: https://bugzilla.redhat.com/show_bug.cgi?id=1550097 This patch enables GRE tests to run even if the buggy `ip` is being used. Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> --- tests/system-traffic.at | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)