From patchwork Tue Jan 30 23:40:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Rose X-Patchwork-Id: 867714 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="q1ql4Lsb"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zWNDh47MFz9s75 for ; Wed, 31 Jan 2018 10:41:08 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 40709F23; Tue, 30 Jan 2018 23:40:36 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 6F1E9EB8 for ; Tue, 30 Jan 2018 23:40:34 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 21F452F6 for ; Tue, 30 Jan 2018 23:40:34 +0000 (UTC) Received: by mail-pf0-f195.google.com with SMTP id e76so10687742pfk.1 for ; Tue, 30 Jan 2018 15:40:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=itJEjix1S6jHlqBref7rhz5IZXoReuqLnxI1sIjiC08=; b=q1ql4Lsb+AUnPy7k3rVdAJtS12yTxWZEBkyvh3dGXRCdcTvmlMVwHFAjIHqIBzCBEv YyqAGAjBYpjMh0WIN/86veAYqQAnT9TkK3jeYpYY+fXP04Tq5TKOPybXEa5FpXBIGBYo LCPJXILKiZWrhmOjs9MA64O7smGfXEYA5p75+WwENYPWuDe2PrrIaQkIuwXipoT5klc/ bnpsqYiJR8ACO2DgkFKT/nzwARcYRQ0YXZT4FmuRwpWRvTdmZeyG6I40hV6uqNa7WlU/ UUEcZiFwqwkTMDSnk+7yN0YHhfvgU6VScWPfGNWFsA3UG5oyqQTfn8cbyhW2lxW+2XXV si8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=itJEjix1S6jHlqBref7rhz5IZXoReuqLnxI1sIjiC08=; b=gxRT6WeZDCy1iM0XQ0DDSikG/Ovy0/Rrid0HQlQ3payxzd0EvHE1G0EHxOUzjwTw2e +gQ6rV34gfb0Rl8LRonzUr4v6AI4+a5Nawb49KGy3zcpWU08lrtyL8dZPMtLFAOiT/XD UPwL7hVHiPnXnrfjb1PxtOTVzGmKZtB9FBgw1xPhjJqNVO2BSjhWXtl69B1Cy0VNdpsz SJNxNpYjAQSt8ttYVpou65axG6dMIau2NLwTeqCkPAbmV9qBOtelbipErLqvFM50Skhl DSmQXAEHUlHMXFTQFjLyFVRINoK14maUVEkSdqe4Cerl+WW/+2Qdilx7+9Nled55wOj8 y2Zg== X-Gm-Message-State: AKwxytet/oZBGnFj3z7mapmhJAZWHORvoMfU2O/Xdk04mgtTNJedi95z oP2/mWDlkOEsv2XXmu7UWlXblA== X-Google-Smtp-Source: AH8x224i7w9WleCLHJkSHLoYz0enfiVCkDdyuZatZIYq8XID/Wiv/39JAEmSHRN9nhLvOpQcR/Ajdw== X-Received: by 10.98.8.86 with SMTP id c83mr31913173pfd.84.1517355633371; Tue, 30 Jan 2018 15:40:33 -0800 (PST) Received: from gizo.domain (184-100-240-187.ptld.qwest.net. [184.100.240.187]) by smtp.gmail.com with ESMTPSA id q16sm41403851pfg.124.2018.01.30.15.40.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jan 2018 15:40:32 -0800 (PST) From: Greg Rose To: dev@openvswitch.org Date: Tue, 30 Jan 2018 15:40:03 -0800 Message-Id: <1517355622-26114-2-git-send-email-gvrose8192@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1517355622-26114-1-git-send-email-gvrose8192@gmail.com> References: <1517355622-26114-1-git-send-email-gvrose8192@gmail.com> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 01/20] datapath: Fix netdev_master_upper_dev_link for 4.14 X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org An extended netlink ack has been added for 4.14 - add compat layer changes so that it compiles for all kernels up to and including 4.14. Signed-off-by: Greg Rose --- acinclude.m4 | 3 +++ datapath/linux/compat/include/linux/netdevice.h | 15 ++++++++++++++- datapath/vport-netdev.c | 9 ++++++++- 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index c04c2c6..768c20c 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -795,6 +795,9 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ [OVS_DEFINE([HAVE_LIST_IN_NF_HOOK_OPS])]) OVS_GREP_IFELSE([$KSRC/include/uapi/linux/netfilter/nf_conntrack_common.h], [IP_CT_UNTRACKED]) + OVS_FIND_PARAM_IFELSE([$KSRC/include/linux/netdevice.h], + [netdev_master_upper_dev_link], [extack], + [OVS_DEFINE([HAVE_UPPER_DEV_LINK_EXTACK])]) if cmp -s datapath/linux/kcompat.h.new \ datapath/linux/kcompat.h >/dev/null 2>&1; then diff --git a/datapath/linux/compat/include/linux/netdevice.h b/datapath/linux/compat/include/linux/netdevice.h index 3c3cf42..c460332 100644 --- a/datapath/linux/compat/include/linux/netdevice.h +++ b/datapath/linux/compat/include/linux/netdevice.h @@ -101,13 +101,26 @@ static inline bool netif_needs_gso(struct sk_buff *skb, #ifndef HAVE_NETDEV_MASTER_UPPER_DEV_LINK_RH static inline int rpl_netdev_master_upper_dev_link(struct net_device *dev, struct net_device *upper_dev, - void *upper_priv, void *upper_info) + void *upper_priv, + void *upper_info, void *extack) { return netdev_master_upper_dev_link(dev, upper_dev); } #define netdev_master_upper_dev_link rpl_netdev_master_upper_dev_link #endif +#else +#ifndef HAVE_UPPER_DEV_LINK_EXTACK +static inline int rpl_netdev_master_upper_dev_link(struct net_device *dev, + struct net_device *upper_dev, + void *upper_priv, + void *upper_info, void *extack) +{ + return netdev_master_upper_dev_link(dev, upper_dev, upper_priv, + upper_info); +} +#define netdev_master_upper_dev_link rpl_netdev_master_upper_dev_link +#endif #endif #if LINUX_VERSION_CODE < KERNEL_VERSION(3,16,0) diff --git a/datapath/vport-netdev.c b/datapath/vport-netdev.c index 697c442..e2d8eaf 100644 --- a/datapath/vport-netdev.c +++ b/datapath/vport-netdev.c @@ -112,8 +112,15 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name) } rtnl_lock(); +#ifdef HAVE_NETDEV_MASTER_UPPER_DEV_LINK_RH err = netdev_master_upper_dev_link(vport->dev, - get_dpdev(vport->dp), NULL, NULL); + get_dpdev(vport->dp), + NULL, NULL); +#else + err = netdev_master_upper_dev_link(vport->dev, + get_dpdev(vport->dp), + NULL, NULL, NULL); +#endif if (err) goto error_unlock;