From patchwork Sat Oct 28 17:31:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 831627 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OPWjB3gK"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yPSWH2RGMz9rxj for ; Sun, 29 Oct 2017 04:32:59 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 0DBEF93C; Sat, 28 Oct 2017 17:32:19 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 8EF382C for ; Sat, 28 Oct 2017 17:32:17 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8522646F for ; Sat, 28 Oct 2017 17:32:16 +0000 (UTC) Received: by mail-pg0-f66.google.com with SMTP id g6so7748371pgn.6 for ; Sat, 28 Oct 2017 10:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=JyxHRI48mmmHZ9PMsr9EixHkCEI4cUjtumUd8Zkinkw=; b=OPWjB3gKMsyalPwn+LOgEcMOT/69cgrVLMrcBsefg68iNtkvefx/p016o8O3TDit9g v6nyH4J02/jY25mGrgzjl3xJ0V3XimPbD55dv8dl/a1ipfeDy8KAk3HJ+brARCuOC82H Xgy/pH1gd9Y85qAU82VwpFyG9GvvZxKqOeApGWoOCSwLQywXviEDMwYjX4xBd1XxtOSU zIr5VuokmVI6iXYc/kBstBA89tc9AYsrvdHsWD0xic8dxENHlhfgAIqZizOPCvMj18vt f2A7tZVud8N33GReLYZQl6hl5PGqvl00kYzON6o2EFnAK14xndiQmtsHSAXV6UqiKvJc OcZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=JyxHRI48mmmHZ9PMsr9EixHkCEI4cUjtumUd8Zkinkw=; b=s7ETzizBtPNETOf4AqlTlS4gFfFjaaGp3konQduyvrTbVDqdAUwI0s8wkT2NdZH3Cf 60QspCF6VcIxWpZ3301iwYX1l4+W1l2EzlJU1fYp3EW+rA1CjkiCp0mRs6fOptzlBXw4 yTIH7zwNRdx1XwhCqJdnlHCR2cr40pYTCZa0PG+QJrQwtsejlxWbbDOiIrHnDRflaTjL /YIVnXwYBKgwxk5tHj+Dmjyr10vtFqwlPwkRzfronAUHTAHg/XCcK6YFSuUJiwCQ0RMw ZRuVLNV+YIPAI4LH2TxEPeaAMfK/PmI+2ekf2IAfaamPBrAKtm9Eznx6hHe6+rSyQOeq nhtg== X-Gm-Message-State: AMCzsaVfT+VnWpE5Yk/9k2Mh4rfoSzFAdl16ehSi669GPHX8899eDhjJ O9+vkqCqxjcDrxqJSlE7fjPQkAUV X-Google-Smtp-Source: ABhQp+QYyfX5f7Wod+rMsSciYYbM1V3Z6/X4Phaytr2plMhQsT33SiStu25CUiLsVTipy84d5seSVg== X-Received: by 10.159.195.7 with SMTP id bd7mr3353665plb.366.1509211935935; Sat, 28 Oct 2017 10:32:15 -0700 (PDT) Received: from sc9-mailhost3.vmware.com ([24.5.191.4]) by smtp.gmail.com with ESMTPSA id x1sm18675418pfh.113.2017.10.28.10.32.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 28 Oct 2017 10:32:15 -0700 (PDT) From: William Tu To: ovs-dev@openvswitch.org Date: Sat, 28 Oct 2017 10:31:48 -0700 Message-Id: <1509211918-14829-2-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1509211918-14829-1-git-send-email-u9012063@gmail.com> References: <1509211918-14829-1-git-send-email-u9012063@gmail.com> X-Spam-Status: No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 01/11] dp-packet: fix possible null pointer argument X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Clang reports possible null pointer argument to the memcpy src. This is due to at dp_packet_clone_data_with_headroom, the dp_packet *b might have a NULL base due to allocating a dp_packet with size = 0. Fix it by adding ovs_assert to satisfy clang. Signed-off-by: William Tu --- lib/dp-packet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/dp-packet.c b/lib/dp-packet.c index 443c22504379..f48e195a51d2 100644 --- a/lib/dp-packet.c +++ b/lib/dp-packet.c @@ -222,6 +222,7 @@ dp_packet_copy__(struct dp_packet *b, uint8_t *new_base, size_t copy_headroom = MIN(old_headroom, new_headroom); size_t copy_tailroom = MIN(old_tailroom, new_tailroom); + ovs_assert(old_base); memcpy(&new_base[new_headroom - copy_headroom], &old_base[old_headroom - copy_headroom], copy_headroom + dp_packet_size(b) + copy_tailroom);