diff mbox

[ovs-dev] ovsdb-types: Fix memory leak on error path.

Message ID 1498479343-17168-1-git-send-email-wangyunjian@huawei.com
State Accepted
Headers show

Commit Message

wangyunjian June 26, 2017, 12:15 p.m. UTC 
From: Yunjian Wang <wangyunjian@huawei.com>

Fixes: bd76d25d8b3b("ovsdb: Add simple constraints.")
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 lib/ovsdb-types.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ben Pfaff July 12, 2017, 4:43 a.m. UTC | #1 
On Mon, Jun 26, 2017 at 08:15:43PM +0800, w00273186 wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> Fixes: bd76d25d8b3b("ovsdb: Add simple constraints.")
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>

Thanks.  Good catch!  I applied this to master and backported as far as
branch-2.0.
diff mbox

Patch

diff --git a/lib/ovsdb-types.c b/lib/ovsdb-types.c
index 20a8444..50a32a7 100644
--- a/lib/ovsdb-types.c
+++ b/lib/ovsdb-types.c
@@ -364,6 +364,7 @@  ovsdb_base_type_from_json(struct ovsdb_base_type *base,
 
     error = ovsdb_atomic_type_from_json(&base->type, type);
     if (error) {
+        ovsdb_error_destroy(ovsdb_parser_destroy(&parser));
         return error;
     }