Message ID | 1496762778-31779-1-git-send-email-ciara.loftus@intel.com |
---|---|
State | Accepted |
Headers | show |
On Tue, 2017-06-06 at 16:26 +0100, Ciara Loftus wrote: > Signed-off-by: Ciara Loftus <ciara.loftus@intel.com> I couldn't find where this changed (the only related commit was 69876ed, but that references the previous naming format) but I trust you know what you're talking about. From the docs side: Acked-by: Stephen Finucane <stephen@that.guru> > --- > Documentation/howto/dpdk.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/howto/dpdk.rst b/Documentation/howto/dpdk.rst > index f3c7aff..93248b4 100644 > --- a/Documentation/howto/dpdk.rst > +++ b/Documentation/howto/dpdk.rst > @@ -361,7 +361,7 @@ Virtual DPDK devices which do not have PCI addresses can be added using a > different format for 'dpdk-devargs'. > > Typically, the format expected is 'eth_<driver_name><x>' where 'x' is a > -number between 0 and RTE_MAX_ETHPORTS -1 (31). > +unique identifier of your choice for the given port. > > For example to add a dpdk port that uses the 'null' DPDK PMD driver:: >
On Wed, 2017-06-07 at 15:33 +0100, Stephen Finucane wrote: > On Tue, 2017-06-06 at 16:26 +0100, Ciara Loftus wrote: > > Signed-off-by: Ciara Loftus <ciara.loftus@intel.com> > > I couldn't find where this changed (the only related commit was 69876ed, but that references the > previous naming format) but I trust you know what you're talking about. From the docs side: > > Acked-by: Stephen Finucane <stephen@that.guru> ...though you should probably fix 'dpdk-devargs' in 'vswitchd/vswitch.xml', per the above commit. Stephen > > > --- > > Documentation/howto/dpdk.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/howto/dpdk.rst b/Documentation/howto/dpdk.rst > > index f3c7aff..93248b4 100644 > > --- a/Documentation/howto/dpdk.rst > > +++ b/Documentation/howto/dpdk.rst > > @@ -361,7 +361,7 @@ Virtual DPDK devices which do not have PCI addresses can be added using a > > different format for 'dpdk-devargs'. > > > > Typically, the format expected is 'eth_<driver_name><x>' where 'x' is a > > -number between 0 and RTE_MAX_ETHPORTS -1 (31). > > +unique identifier of your choice for the given port. > > > > For example to add a dpdk port that uses the 'null' DPDK PMD driver:: > > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Jun 07, 2017 at 03:33:49PM +0100, Stephen Finucane wrote: > On Tue, 2017-06-06 at 16:26 +0100, Ciara Loftus wrote: > > Signed-off-by: Ciara Loftus <ciara.loftus@intel.com> > > I couldn't find where this changed (the only related commit was 69876ed, but that references the > previous naming format) but I trust you know what you're talking about. From the docs side: > > Acked-by: Stephen Finucane <stephen@that.guru> Thanks Ciara and Stephen. I updated vswitch.xml also and applied this to master.
diff --git a/Documentation/howto/dpdk.rst b/Documentation/howto/dpdk.rst index f3c7aff..93248b4 100644 --- a/Documentation/howto/dpdk.rst +++ b/Documentation/howto/dpdk.rst @@ -361,7 +361,7 @@ Virtual DPDK devices which do not have PCI addresses can be added using a different format for 'dpdk-devargs'. Typically, the format expected is 'eth_<driver_name><x>' where 'x' is a -number between 0 and RTE_MAX_ETHPORTS -1 (31). +unique identifier of your choice for the given port. For example to add a dpdk port that uses the 'null' DPDK PMD driver::
Signed-off-by: Ciara Loftus <ciara.loftus@intel.com> --- Documentation/howto/dpdk.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)