Message ID | 1493824097-47495-8-git-send-email-roid@mellanox.com |
---|---|
State | Changes Requested |
Headers | show |
On Wed, May 03, 2017 at 06:07:58PM +0300, Roi Dayan wrote: > From: Paul Blakey <paulb@mellanox.com> > > Signed-off-by: Paul Blakey <paulb@mellanox.com> > Reviewed-by: Roi Dayan <roid@mellanox.com> > Reviewed-by: Simon Horman <simon.horman@netronome.com> This does not appear to address Flavio Leitner's review of v7 of this patch.
On 08/05/2017 15:56, Simon Horman wrote: > On Wed, May 03, 2017 at 06:07:58PM +0300, Roi Dayan wrote: >> From: Paul Blakey <paulb@mellanox.com> >> >> Signed-off-by: Paul Blakey <paulb@mellanox.com> >> Reviewed-by: Roi Dayan <roid@mellanox.com> >> Reviewed-by: Simon Horman <simon.horman@netronome.com> > > This does not appear to address Flavio Leitner's review of v7 of this patch. > email issues. addressed for V9.
diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c index eb5e79a..b12a048 100644 --- a/lib/netdev-tc-offloads.c +++ b/lib/netdev-tc-offloads.c @@ -75,10 +75,20 @@ VLOG_DEFINE_THIS_MODULE(netdev_tc_offloads); +static struct vlog_rate_limit rl_err = VLOG_RATE_LIMIT_INIT(9999, 5); + int -netdev_tc_flow_flush(struct netdev *netdev OVS_UNUSED) +netdev_tc_flow_flush(struct netdev *netdev) { - return EOPNOTSUPP; + int ifindex = netdev_get_ifindex(netdev); + + if (ifindex < 0) { + VLOG_ERR_RL(&rl_err, "failed to get ifindex for %s: %s", + netdev_get_name(netdev), ovs_strerror(-ifindex)); + return -ifindex; + } + + return tc_flush(ifindex); } int