From patchwork Sun Apr 30 16:15:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Qiu X-Patchwork-Id: 756892 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wGCPk0H3lz9s7p for ; Mon, 1 May 2017 02:17:30 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nuTOZer9"; dkim-atps=neutral Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 9D362957; Sun, 30 Apr 2017 16:16:24 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 6809F71F for ; Sun, 30 Apr 2017 16:16:23 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 5E18FD3 for ; Sun, 30 Apr 2017 16:16:22 +0000 (UTC) Received: by mail-pg0-f68.google.com with SMTP id t7so12917927pgt.1 for ; Sun, 30 Apr 2017 09:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=f4s6EYrupM8cUYPDlVg1JGRXi/v7GtnemDekn60b15g=; b=nuTOZer9yXI2z6/geQxJcjF5tOMO5j+HKI+Bpg4XwGYMuGjp4jxUeYEEYxC1+dZI6M 6tRVxdE8kA95L9IvixMuexfDZYQ6fSfomF2hXR2wVTfiO/yC1PJlhYAVzK+P62Qkv+zJ gbVXFVYc94agNfXmdSd/N+ZZiv05FU6SMnRIQygh+WIgdZKlpfNgZIjOevblLe94AkA2 gpXnbawDfrS7Qj2YxsfrWMDEfz+/jCUCRZSVFIF4qgK/ZYYDC1OKBkqjPSJ59nMTmy+r RUZYmg5x4b4tDdoHAfMhKUoDXkbxsPZLmaxolSceZRtOu3uWyWhDorv+25nSYI/UOMYa HDvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=f4s6EYrupM8cUYPDlVg1JGRXi/v7GtnemDekn60b15g=; b=nImxn2vE2NZRK9dPr9bfuk3jJo9xjazFAmrAuogXPqNoqs6DeEnnYNEdfwZ+yG0Pdo DC1s2Rus5d5rzy/AX3qY2JGejhLOphsyBxFkmn+Vk3VP56y6gjSTGG68NosE6xCLO3iJ NKgO1c2nApDpkAA9qz1LQLgXZxZItG9Xj7KDSfJTm0s5pd4Oeq7TDjoEDaz9ZZTu7u0L x/fSOIIgXnLqc4He8hGoId/iq79Ew59FimfJ+RvJ1E+SMl7tbywrpTrJt3sBuRdTqq6t cziN14yDJ4N1t5KHpUZhJdO3ykLq5/xG4p1ThpJs+Fx1SW7h8SVwYC01Oq9jDhnK23wX j7Ng== X-Gm-Message-State: AN3rC/4vlTHZUOa2kojBsKdjl+JVMdHQcXjndPEQqV7UR9vYO3xwxt7e TPf3NUGoMOt5Tg== X-Received: by 10.99.60.21 with SMTP id j21mr8255195pga.99.1493568982038; Sun, 30 Apr 2017 09:16:22 -0700 (PDT) Received: from localhost.localdomain (softbank060067191191.bbtec.net. [60.67.191.191]) by smtp.gmail.com with ESMTPSA id b74sm20900540pfl.58.2017.04.30.09.16.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 30 Apr 2017 09:16:21 -0700 (PDT) From: Michael Qiu To: dev@openvswitch.org Date: Mon, 1 May 2017 00:15:31 +0800 Message-Id: <1493568934-3099-3-git-send-email-qdy220091330@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1493568934-3099-1-git-send-email-qdy220091330@gmail.com> References: <1493568934-3099-1-git-send-email-qdy220091330@gmail.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Cc: Michael Qiu Subject: [ovs-dev] [PATCH 2/5] lib/dp-packet: copy additional packet info when do packet copy X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org From: Michael Qiu Currently, when doing packet copy, lots of DPDK mbuf's info will be missed, like packet type, ol_flags, etc. Those information is very important for DPDK to do packets processing. Signed-off-by: Michael Qiu --- lib/dp-packet.c | 3 +++ lib/netdev-dpdk.c | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/lib/dp-packet.c b/lib/dp-packet.c index 4108cfa..24d418f 100644 --- a/lib/dp-packet.c +++ b/lib/dp-packet.c @@ -175,6 +175,9 @@ dp_packet_clone_with_headroom(const struct dp_packet *buffer, size_t headroom) new_buffer->cutlen = buffer->cutlen; #ifdef DPDK_NETDEV new_buffer->mbuf.ol_flags = buffer->mbuf.ol_flags; + new_buffer->mbuf.tx_offload = buffer->mbuf.tx_offload; + new_buffer->mbuf.packet_type = buffer->mbuf.packet_type; + new_buffer->mbuf.nb_segs = buffer->mbuf.nb_segs; #else new_buffer->rss_hash_valid = buffer->rss_hash_valid; #endif diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 27b4ee2..ad92504 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1589,6 +1589,10 @@ dpdk_do_tx_copy(struct netdev *netdev, int qid, struct dp_packet_batch *batch) memcpy(rte_pktmbuf_mtod(mbufs[newcnt], void *), dp_packet_data(batch->packets[i]), size); + mbufs[newcnt]->nb_segs = batch->packets[i]->mbuf.nb_segs; + mbufs[newcnt]->ol_flags = batch->packets[i]->mbuf.ol_flags; + mbufs[newcnt]->packet_type = batch->packets[i]->mbuf.packet_type; + mbufs[newcnt]->tx_offload = batch->packets[i]->mbuf.tx_offload; rte_pktmbuf_data_len(mbufs[newcnt]) = size; rte_pktmbuf_pkt_len(mbufs[newcnt]) = size;