| Message ID | 1486502303-88648-1-git-send-email-bhanuprakash.bodireddy@intel.com |
|---|---|
| State | Accepted |
| Headers | show |
Hi, Two really minor comments: > + > +Extended Statistics > +------------------- > + > +DPDK Extended Statistics API allows PMD to expose unique set of statistics. > +The Extended statistics are implemented and supported only for DPDK physical Add space before vHost; should be "DPDK vHost ports" or ""dpdk vHost ports" I would assume ? > +and dpdkvHost ports. > + > +To enable statistics, you have to enable OpenFlow 1.4 support for OVS. Typo: verion-> should be: version : > +Configure bridge br0 to support OpenFlow verion 1.4:: > + Regards, Rami Rosen
On Tue, Feb 07, 2017 at 09:18:22PM +0000, Bhanuprakash Bodireddy wrote: > Add instructions on how to retrieve extended statistics for DPDK physical > and vhost ports. > > Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com> Applied to master, let me know if this should also be on branch-2.7. Thank you! I folded in Rami's suggestions.
>-----Original Message----- >From: Ben Pfaff [mailto:blp@ovn.org] >Sent: Wednesday, March 8, 2017 12:40 AM >To: Bodireddy, Bhanuprakash <bhanuprakash.bodireddy@intel.com> >Cc: dev@openvswitch.org >Subject: Re: [ovs-dev] [PATCH 1/2] Documentation: Update DPDK doc with >extended statistics. > >On Tue, Feb 07, 2017 at 09:18:22PM +0000, Bhanuprakash Bodireddy wrote: >> Add instructions on how to retrieve extended statistics for DPDK >> physical and vhost ports. >> >> Signed-off-by: Bhanuprakash Bodireddy >> <bhanuprakash.bodireddy@intel.com> > >Applied to master, let me know if this should also be on branch-2.7. Thanks Ben. Please apply this patch to 2.7 branch too. Regards, Bhanuprakash.
diff --git a/Documentation/howto/dpdk.rst b/Documentation/howto/dpdk.rst index d1e6e89..bc921cb 100644 --- a/Documentation/howto/dpdk.rst +++ b/Documentation/howto/dpdk.rst @@ -299,6 +299,33 @@ physical ports which in turn effects the non-tunnel traffic performance. So it is advised to turn off the Rx checksum offload for non-tunnel traffic use cases to achieve the best performance. +.. _extended-statistics: + +Extended Statistics +------------------- + +DPDK Extended Statistics API allows PMD to expose unique set of statistics. +The Extended statistics are implemented and supported only for DPDK physical +and dpdkvHost ports. + +To enable statistics, you have to enable OpenFlow 1.4 support for OVS. +Configure bridge br0 to support OpenFlow verion 1.4:: + + $ ovs-vsctl set bridge br0 datapath_type=netdev \ + protocols=OpenFlow10,OpenFlow11,OpenFlow12,OpenFlow13,OpenFlow14 + +Check the OVSDB protocols column in the bridge table if OpenFlow 1.4 support +is enabled for OVS:: + + $ ovsdb-client dump Bridge protocols + +Query the port statistics by explicitly specifying -O OpenFlow14 option:: + + $ ovs-ofctl -O OpenFlow14 dump-ports br0 + +Note: vHost ports supports only partial statistics. RX packet size based +counter are only supported and doesn't include TX packet size counters. + .. _port-hotplug: Port Hotplug
Add instructions on how to retrieve extended statistics for DPDK physical and vhost ports. Signed-off-by: Bhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com> --- Documentation/howto/dpdk.rst | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)