[ovs-dev,V3,5/5] Python tests: Enable python tests on Windows

From: Alin Balutoiu <abalutoiu@cloudbasesolutions.com>

Updated the Readme with additional library required for
the python tests.

Remove the code which disable python tests to
be run on Windows.

Signed-off-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com>
---
V2: Changed code-block from bash to console.
V3: Changed Signed-off-by name.
---
 Documentation/intro/install/windows.rst | 7 +++++++
 tests/atlocal.in                        | 8 --------
 2 files changed, 7 insertions(+), 8 deletions(-)

On 3 January 2017 at 08:46, Alin Balutoiu <abalutoiu@cloudbasesolutions.com>
wrote:

> From: Alin Balutoiu <abalutoiu@cloudbasesolutions.com>
>
> Updated the Readme with additional library required for
> the python tests.
>
> Remove the code which disable python tests to
> be run on Windows.
>
> Signed-off-by: Alin Balutoiu <abalutoiu@cloudbasesolutions.com>
> ---
> V2: Changed code-block from bash to console.
> V3: Changed Signed-off-by name.
> ---
>  Documentation/intro/install/windows.rst | 7 +++++++
>  tests/atlocal.in                        | 8 --------
>  2 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/intro/install/windows.rst
> b/Documentation/intro/install/windows.rst
> index 9bd1813..47dd68e 100644
> --- a/Documentation/intro/install/windows.rst
> +++ b/Documentation/intro/install/windows.rst
> @@ -60,6 +60,13 @@ The following explains the steps in some detail.
>
>    Install the latest Python 2.x from python.org and verify that its path
> is
>    part of Windows' PATH environment variable.
> +  We require that you have Python six and pypiwin32 libraries installed.
> +  The libraries can be installed via pip command:
> +
> +   .. code-block:: console
> +
> +      $ pip install six
> +      $ pip install pypiwin32
>

Does "pip" automatically come when one installs Python from python.org? Or
do we need to install it separately. If it is the latter, then I think it
makes sense to add that information too.


>
>  - Visual Studio
>
> diff --git a/tests/atlocal.in b/tests/atlocal.in
> index 1353b46..9fbab39 100644
> --- a/tests/atlocal.in
> +++ b/tests/atlocal.in
> @@ -109,14 +109,6 @@ else
>      HAVE_IPV6=no
>  fi
>
> -# XXX: Disable Python related tests on Windows because Open vSwitch code
> -# written in Python has not been ported to the Windows platform. We will
> -# need to remove the next block after porting is complete.
> -if test "$IS_WIN32" = "yes"; then
> -    HAVE_PYTHON="no"
> -    HAVE_PYTHON3="no"
> -fi
> -
>  if test "$HAVE_PYTHON" = "yes" \
>     && test "x`$PYTHON $abs_top_srcdir/tests/test-l7.py --help | grep
> 'ftp'`" != x; then
>      HAVE_PYFTPDLIB="yes"
> --
> 2.10.0.windows.1
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>

Yes, "pip" is included in the MSI installer from http://python.org

> From: Guru Shetty [mailto:guru@ovn.org] 
> Sent: Tuesday, January 3, 2017 9:33 PM
> To: Alin Balutoiu <abalutoiu@cloudbasesolutions.com>
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH V3 5/5] Python tests: Enable python tests on Windows
> 
> 
> 
> On 3 January 2017 at 08:46, Alin Balutoiu <mailto:abalutoiu@cloudbasesolutions.com> wrote:
> From: Alin Balutoiu <mailto:abalutoiu@cloudbasesolutions.com>
> 
> Updated the Readme with additional library required for
> the python tests.
> 
> Remove the code which disable python tests to
> be run on Windows.
> 
> Signed-off-by: Alin Balutoiu <mailto:abalutoiu@cloudbasesolutions.com>
> ---
> V2: Changed code-block from bash to console.
> V3: Changed Signed-off-by name.
> ---
>  Documentation/intro/install/windows.rst | 7 +++++++
>  tests/http://atlocal.in                        | 8 --------
>  2 files changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/intro/install/windows.rst b/Documentation/intro/install/windows.rst
> index 9bd1813..47dd68e 100644
> --- a/Documentation/intro/install/windows.rst
> +++ b/Documentation/intro/install/windows.rst
> @@ -60,6 +60,13 @@ The following explains the steps in some detail.
> 
>    Install the latest Python 2.x from http://python.org and verify that its path is
>    part of Windows' PATH environment variable.
> +  We require that you have Python six and pypiwin32 libraries installed.
> +  The libraries can be installed via pip command:
> +
> +   .. code-block:: console
> +
> +      $ pip install six
> +      $ pip install pypiwin32
> 
> Does "pip" automatically come when one installs Python from http://python.org? Or do we need to install it separately. If it is the latter, then I think it makes sense to add that information too.
>  
> 
>  - Visual Studio
> 
> diff --git a/tests/http://atlocal.in b/tests/http://atlocal.in
> index 1353b46..9fbab39 100644
> --- a/tests/http://atlocal.in
> +++ b/tests/http://atlocal.in
> @@ -109,14 +109,6 @@ else
>      HAVE_IPV6=no
>  fi
> 
> -# XXX: Disable Python related tests on Windows because Open vSwitch code
> -# written in Python has not been ported to the Windows platform. We will
> -# need to remove the next block after porting is complete.
> -if test "$IS_WIN32" = "yes"; then
> -    HAVE_PYTHON="no"
> -    HAVE_PYTHON3="no"
> -fi
> -
>  if test "$HAVE_PYTHON" = "yes" \
>     && test "x`$PYTHON $abs_top_srcdir/tests/test-l7.py --help | grep 'ftp'`" != x; then
>      HAVE_PYFTPDLIB="yes"
> --
> 2.10.0.windows.1
> _______________________________________________
> dev mailing list
> mailto:dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev