From patchwork Tue Nov 15 09:49:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thadeu Lima de Souza Cascardo X-Patchwork-Id: 694928 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tJ2hX51Kmz9t2D for ; Tue, 15 Nov 2016 20:51:08 +1100 (AEDT) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id F141DB76; Tue, 15 Nov 2016 09:50:08 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 443B3B5A for ; Tue, 15 Nov 2016 09:50:07 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id F32AC291 for ; Tue, 15 Nov 2016 09:50:06 +0000 (UTC) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 825E68F275 for ; Tue, 15 Nov 2016 09:50:06 +0000 (UTC) Received: from indiana.gru.redhat.com (ovpn-116-76.phx2.redhat.com [10.3.116.76]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAF9o0Uo014920 for ; Tue, 15 Nov 2016 04:50:05 -0500 From: Thadeu Lima de Souza Cascardo To: dev@openvswitch.org Date: Tue, 15 Nov 2016 07:49:46 -0200 Message-Id: <1479203387-17549-3-git-send-email-cascardo@redhat.com> In-Reply-To: <1479203387-17549-1-git-send-email-cascardo@redhat.com> References: <1479203387-17549-1-git-send-email-cascardo@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 15 Nov 2016 09:50:06 +0000 (UTC) X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 2/3] ovs-router: report error when failing to insert route X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Signed-off-by: Thadeu Lima de Souza Cascardo --- lib/ovs-router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ovs-router.c b/lib/ovs-router.c index e27514a..e29d462 100644 --- a/lib/ovs-router.c +++ b/lib/ovs-router.c @@ -316,7 +316,7 @@ ovs_router_add(struct unixctl_conn *conn, int argc, } err = ovs_router_insert__(plen + 32, &ip6, plen, argv[2], &gw6); if (err) { - unixctl_command_reply(conn, "Error while inserting route."); + unixctl_command_reply_error(conn, "Error while inserting route."); } else { unixctl_command_reply(conn, "OK"); }