diff mbox

[ovs-dev] ovn-sbctl: document logging and common options in man page

Message ID 1479149082-27624-1-git-send-email-lrichard@redhat.com
State Accepted
Headers show

Commit Message

Lance Richardson Nov. 14, 2016, 6:44 p.m. UTC
The ovn-sbctl is currently missing a description of logging and
common (-h/--help/-V/--version) command-line options. Add them
by including corresponding man page fragments.

Signed-off-by: Lance Richardson <lrichard@redhat.com>
---
 manpages.mk                  | 4 ++++
 ovn/utilities/ovn-sbctl.8.in | 3 +++
 2 files changed, 7 insertions(+)

Comments

Russell Bryant Nov. 14, 2016, 8:57 p.m. UTC | #1
On Mon, Nov 14, 2016 at 1:44 PM, Lance Richardson <lrichard@redhat.com>
wrote:

> The ovn-sbctl is currently missing a description of logging and
> common (-h/--help/-V/--version) command-line options. Add them
> by including corresponding man page fragments.
>
> Signed-off-by: Lance Richardson <lrichard@redhat.com>
> ---
>  manpages.mk                  | 4 ++++
>  ovn/utilities/ovn-sbctl.8.in | 3 +++
>  2 files changed, 7 insertions(+)
>

Thanks!  applied to master.
Russell Bryant Nov. 14, 2016, 9:52 p.m. UTC | #2
On Mon, Nov 14, 2016 at 3:57 PM, Russell Bryant <russell@ovn.org> wrote:

>
> On Mon, Nov 14, 2016 at 1:44 PM, Lance Richardson <lrichard@redhat.com>
> wrote:
>
>> The ovn-sbctl is currently missing a description of logging and
>> common (-h/--help/-V/--version) command-line options. Add them
>> by including corresponding man page fragments.
>>
>> Signed-off-by: Lance Richardson <lrichard@redhat.com>
>> ---
>>  manpages.mk                  | 4 ++++
>>  ovn/utilities/ovn-sbctl.8.in | 3 +++
>>  2 files changed, 7 insertions(+)
>>
>
> Thanks!  applied to master.
>

and backported to branch-2.6.
diff mbox

Patch

diff --git a/manpages.mk b/manpages.mk
index 2ff7658..2fb8ef4 100644
--- a/manpages.mk
+++ b/manpages.mk
@@ -2,13 +2,17 @@ 
 
 ovn/utilities/ovn-sbctl.8: \
 	ovn/utilities/ovn-sbctl.8.in \
+	lib/common.man \
 	lib/db-ctl-base.man \
 	lib/table.man \
+	lib/vlog.man \
 	ovsdb/remote-active.man \
 	ovsdb/remote-passive.man
 ovn/utilities/ovn-sbctl.8.in:
+lib/common.man:
 lib/db-ctl-base.man:
 lib/table.man:
+lib/vlog.man:
 ovsdb/remote-active.man:
 ovsdb/remote-passive.man:
 
diff --git a/ovn/utilities/ovn-sbctl.8.in b/ovn/utilities/ovn-sbctl.8.in
index 5f0462a..8036397 100644
--- a/ovn/utilities/ovn-sbctl.8.in
+++ b/ovn/utilities/ovn-sbctl.8.in
@@ -97,6 +97,9 @@  to approximately \fIsecs\fR seconds.  If the timeout expires,
 would normally happen only if the database cannot be contacted, or if
 the system is overloaded.)
 .
+.so lib/vlog.man
+.so lib/common.man
+.
 .SS "Table Formatting Options"
 These options control the format of output from the \fBlist\fR and
 \fBfind\fR commands.