From patchwork Fri Nov 4 17:06:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Darrell Ball X-Patchwork-Id: 691342 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3t9St40x7qz9vFL for ; Sat, 5 Nov 2016 04:06:36 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZL4IoPJ4"; dkim-atps=neutral Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 541551060F; Fri, 4 Nov 2016 10:06:33 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id DEA8B1060A for ; Fri, 4 Nov 2016 10:06:31 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id 59ADF16306D for ; Fri, 4 Nov 2016 11:06:31 -0600 (MDT) X-ASG-Debug-ID: 1478279190-0b3237204590ca00001-byXFYA Received: from mx1-pf2.cudamail.com ([192.168.24.2]) by bar6.cudamail.com with ESMTP id uc3O9uNzGnS31fCV (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 04 Nov 2016 11:06:30 -0600 (MDT) X-Barracuda-Envelope-From: dlu998@gmail.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.24.2 Received: from unknown (HELO mail-pf0-f193.google.com) (209.85.192.193) by mx1-pf2.cudamail.com with ESMTPS (AES128-SHA encrypted); 4 Nov 2016 17:06:30 -0000 Received-SPF: pass (mx1-pf2.cudamail.com: SPF record at _netblocks.google.com designates 209.85.192.193 as permitted sender) X-Barracuda-Apparent-Source-IP: 209.85.192.193 X-Barracuda-RBL-IP: 209.85.192.193 Received: by mail-pf0-f193.google.com with SMTP id i88so8450822pfk.2 for ; Fri, 04 Nov 2016 10:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TrB0MMdehv0tjEcR5YlypR1sOQPVgi7zQnSYedGET8Y=; b=ZL4IoPJ4umaKrQzj3liv0RfgV6zrWwVJE9KlXt1NgSsYCsVWdmdN9aueFxw1gMaN4D GrPR1JaGojgsK2m8zVM8nARZOlvoVXdDkj7J0YBdgQgQvBvZ0C3hPdqDZYFSjs6itdAW xN9CAHqvb9rQf7DFil3h06CMZSASYouBpe1mjbxQiA2hKHTHKN+kPSNW91vEWPj/5/iE qcZfSHmUXP3qKzdfry7lrd4GKGgUfamBMnlWYYO2Gk4Us6qigdZlkT4f8BSrMdOwtVgx l1tVfVOO/haHxCn9vA3nZDmICVxZNy/5CSOOgm/Hq5wTQEt0Sr8l/upX38Agf8lmyNbl VUCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TrB0MMdehv0tjEcR5YlypR1sOQPVgi7zQnSYedGET8Y=; b=flgimgYTK3BLr8/1LihBSmVgXqJP4rpVRZpSJFr+Vf9MnxerDIBo+MQSqf5bVAHE+l L4EVgJoMnM6n2YfPQNcxKmn2A6L57Ti7PIgoc50ub8ArwDgA2wKYZXyUXSNqwS/nJez0 TJGJz2KxQyI9rNILZARaCDCFumMOdcBbTZhwuBzVTplz4dW2Avb3x0P4MP3b/NPUXIVe 0mLraFXIDtTXYXnRh0W6hIQ4n1TuhQMMj+HljRqGAa2IK3E8JQje8p8o0tpv9+ehj5Ja fhURHsYS61vB4yn4ulaygj9ZvUIGED6o4eC4MA86iO5Y4eCfaupBqhqb+neYPBqeqBRe 7BTw== X-Gm-Message-State: ABUngvfrPMxLXF2SQ7gZhz/y1R+/oNVCh5pjfwuSmylgnuDd/Tge7lkzwfCYfoQ+pnEDTQ== X-Received: by 10.99.171.75 with SMTP id k11mr23675833pgp.2.1478279189648; Fri, 04 Nov 2016 10:06:29 -0700 (PDT) Received: from ubuntu.localdomain (c-24-4-8-103.hsd1.ca.comcast.net. [24.4.8.103]) by smtp.gmail.com with ESMTPSA id r21sm897210pfd.44.2016.11.04.10.06.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Nov 2016 10:06:29 -0700 (PDT) X-CudaMail-Envelope-Sender: dlu998@gmail.com From: Darrell Ball To: dlu998@gmail.com, dev@openvswitch.org X-CudaMail-MID: CM-E2-1103039136 X-CudaMail-DTE: 110416 X-CudaMail-Originating-IP: 209.85.192.193 Date: Fri, 4 Nov 2016 10:06:16 -0700 X-ASG-Orig-Subj: [##CM-E2-1103039136##][patch_v6 1/3] ovn: Fix arping from vtep-gw physical port. Message-Id: <1478279178-36041-2-git-send-email-dlu998@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1478279178-36041-1-git-send-email-dlu998@gmail.com> References: <1478279178-36041-1-git-send-email-dlu998@gmail.com> X-GBUdb-Analysis: 0, 209.85.192.193, Ugly c=0.436326 p=-0.333333 Source Normal X-MessageSniffer-Rules: 0-0-0-5963-c X-Barracuda-Connect: UNKNOWN[192.168.24.2] X-Barracuda-Start-Time: 1478279190 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 1.10 X-Barracuda-Spam-Status: No, SCORE=1.10 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.0 tests=BSF_SC0_MISMATCH_TO, BSF_SC0_SA_TO_FROM_ADDR_MATCH, BSF_SC5_MJ1963, DKIM_SIGNED, MAILTO_TO_SPAM_ADDR, RDNS_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.34260 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header 0.00 DKIM_SIGNED Domain Keys Identified Mail: message has a signature 0.00 MAILTO_TO_SPAM_ADDR URI: Includes a link to a likely spammer email 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS 0.50 BSF_SC0_SA_TO_FROM_ADDR_MATCH Sender Address Matches Recipient Address 0.50 BSF_SC5_MJ1963 Custom Rule MJ1963 Cc: Ramu Ramamurthy Subject: [ovs-dev] [patch_v6 1/3] ovn: Fix arping from vtep-gw physical port. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" from: Ramu Ramamurthy Currently, arping from a vtep-gw physical-switch port to a VIF IP address does not work. When a physical-switch-port arps for an IP address of a VIF, that arp packet comes into the VIF hypervisor via a vxlan tunnel. That arp packet must not be responded-to by the arp responder table because, potentially, multiple hypervisors could independently respond and confuse L2 learning at the arp originator. Signed-off-by: Ramu Ramamurthy Signed-off-by: Darrell Ball Co-authored-by: Darrell Ball --- ovn/northd/ovn-northd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 07c7b2d..ea6aec9 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -2844,13 +2844,15 @@ build_lswitch_flows(struct hmap *datapaths, struct hmap *ports, } /* Ingress table 10: ARP/ND responder, skip requests coming from localnet - * ports. (priority 100). */ + * and vtep ports. (priority 100); see ovn-northd.8.xml for the + * rationale. */ HMAP_FOR_EACH (op, key_node, ports) { if (!op->nbsp) { continue; } - if (!strcmp(op->nbsp->type, "localnet")) { + if ((!strcmp(op->nbsp->type, "localnet")) || + (!strcmp(op->nbsp->type, "vtep"))) { ds_clear(&match); ds_put_format(&match, "inport == %s", op->json_key); ovn_lflow_add(lflows, op->od, S_SWITCH_IN_ARP_ND_RSP, 100,