| Message ID | 1476793526-5303-2-git-send-email-yamamoto@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Oct 18, 2016 at 09:25:25PM +0900, YAMAMOTO Takashi wrote: > It seems like a non-portable bash extension. > > Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
On Wed, Oct 19, 2016 at 1:47 AM, Ben Pfaff <blp@ovn.org> wrote: > On Tue, Oct 18, 2016 at 09:25:25PM +0900, YAMAMOTO Takashi wrote: > > It seems like a non-portable bash extension. > > > > Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org> > > Acked-by: Ben Pfaff <blp@ovn.org> > thank you. pushed to master.
diff --git a/tests/ovn.at b/tests/ovn.at index caf9f98..da0291f 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -3618,8 +3618,8 @@ test_dhcp() { # (which is 272 in our case) + 8 (padding bytes) + (expected_dhcp_opts / 2) ip_len=`expr 280 + ${#expected_dhcp_opts} / 2` udp_len=`expr $ip_len - 20` - printf -v ip_len "%x" $ip_len - printf -v udp_len "%x" $udp_len + ip_len=$(printf "%x" $ip_len) + udp_len=$(printf "%x" $udp_len) # $ip_len var will be in 3 digits i.e 134. So adding a '0' before $ip_len local reply=${src_mac}${srv_mac}080045100${ip_len}000000008011XXXX${srv_ip}${offer_ip} # udp header and dhcp header.
It seems like a non-portable bash extension. Signed-off-by: YAMAMOTO Takashi <yamamoto@ovn.org> --- tests/ovn.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)