diff mbox

[ovs-dev,5/6] checkpatch: convert some of the warnings

Message ID 1475871477-11608-6-git-send-email-aconole@redhat.com
State Changes Requested
Headers show

Commit Message

Aaron Conole Oct. 7, 2016, 8:17 p.m. UTC
These coding issues are not just things that shouldn't be done.  They are
styles which should never be submitted.

Signed-off-by: Aaron Conole <aconole@redhat.com>
---
 utilities/checkpatch.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff mbox

Patch

diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index c8f21b0..c4361f0 100755
--- a/utilities/checkpatch.py
+++ b/utilities/checkpatch.py
@@ -216,12 +216,11 @@  def ovs_checkpatch_parse(text):
                               lineno)
             if not if_and_for_whitespace_checks(line[1:]):
                 print_line = True
-                print_warning("Improper whitespace around control block",
+                print_error("Improper whitespace around control block",
                               lineno)
             if not if_and_for_end_with_bracket_check(line[1:]):
                 print_line = True
-                print_warning("Inappropriate bracing around statement",
-                              lineno)
+                print_error("Inappropriate bracing around statement", lineno)
             if print_line:
                 print("\n%s\n" % line)
     if __errors or __warnings: