| Message ID | 1475871477-11608-2-git-send-email-aconole@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Aaron Conole <aconole@redhat.com> writes: > The signed-off and co-authors check that was committed is just plain > wrong. The test should be more than 1 'Signed-off-by'. > > Signed-off-by: Aaron Conole <aconole@redhat.com> > --- > utilities/checkpatch.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py > index 754059a..17e5be4 100755 > --- a/utilities/checkpatch.py > +++ b/utilities/checkpatch.py > @@ -167,13 +167,13 @@ def ovs_checkpatch_parse(text): > if scissors.match(line): > parse = parse + 1 > if not skip_signoff_check: > + if len(signatures) + len(co_authors) == 0: > + print_error("No authors?") > if len(signatures) == 0: > print_error("No signatures found.") > - if len(signatures) != 1 + len(co_authors): > + if len(signatures) > 1: > print_error("Too many signoffs; " > "are you missing Co-authored-by lines?") > - if not set(co_authors) <= set(signatures): > - print_error("Co-authored-by/Signed-off-by corruption") > elif is_signature.match(line): > m = is_signature.match(line) > signatures.append(m.group(3)) This patch is wrong. Sorry - consider that this series needs a respin. I'll post a v2.
diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 754059a..17e5be4 100755 --- a/utilities/checkpatch.py +++ b/utilities/checkpatch.py @@ -167,13 +167,13 @@ def ovs_checkpatch_parse(text): if scissors.match(line): parse = parse + 1 if not skip_signoff_check: + if len(signatures) + len(co_authors) == 0: + print_error("No authors?") if len(signatures) == 0: print_error("No signatures found.") - if len(signatures) != 1 + len(co_authors): + if len(signatures) > 1: print_error("Too many signoffs; " "are you missing Co-authored-by lines?") - if not set(co_authors) <= set(signatures): - print_error("Co-authored-by/Signed-off-by corruption") elif is_signature.match(line): m = is_signature.match(line) signatures.append(m.group(3))
The signed-off and co-authors check that was committed is just plain wrong. The test should be more than 1 'Signed-off-by'. Signed-off-by: Aaron Conole <aconole@redhat.com> --- utilities/checkpatch.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)