diff mbox

[ovs-dev,4/7] ovn: Fix race in "ovn -- ipam" test.

Message ID 1475717212-27467-4-git-send-email-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff Oct. 6, 2016, 1:26 a.m. UTC
After setting the subnet, ovn-northd needs to process the changes before
setting the dynamic addresses.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 tests/ovn.at | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gurucharan Shetty Oct. 7, 2016, 2:28 p.m. UTC | #1
On 5 October 2016 at 18:26, Ben Pfaff <blp@ovn.org> wrote:

> After setting the subnet, ovn-northd needs to process the changes before
> setting the dynamic addresses.
>
> Signed-off-by: Ben Pfaff <blp@ovn.org>
>
Acked-by: Gurucharan Shetty <guru@ovn.org>

> ---
>  tests/ovn.at | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/ovn.at b/tests/ovn.at
> index 9baa1df..c4a600a 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
> @@ -4552,7 +4552,7 @@ ovn_start
>  # subnet which should result in an address being allocated for the port.
>  ovn-nbctl ls-add sw0
>  ovn-nbctl lsp-add sw0 p0 -- lsp-set-addresses p0 dynamic
> -ovn-nbctl add Logical-Switch sw0 other_config subnet=192.168.1.0/24
> +ovn-nbctl --wait=sb add Logical-Switch sw0 other_config subnet=
> 192.168.1.0/24
>  AT_CHECK([ovn-nbctl get Logical-Switch-Port p0 dynamic_addresses], [0],
>      ["0a:00:00:00:00:01 192.168.1.2"
>  ])
> --
> 2.1.3
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
diff mbox

Patch

diff --git a/tests/ovn.at b/tests/ovn.at
index 9baa1df..c4a600a 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -4552,7 +4552,7 @@  ovn_start
 # subnet which should result in an address being allocated for the port.
 ovn-nbctl ls-add sw0
 ovn-nbctl lsp-add sw0 p0 -- lsp-set-addresses p0 dynamic
-ovn-nbctl add Logical-Switch sw0 other_config subnet=192.168.1.0/24
+ovn-nbctl --wait=sb add Logical-Switch sw0 other_config subnet=192.168.1.0/24
 AT_CHECK([ovn-nbctl get Logical-Switch-Port p0 dynamic_addresses], [0],
     ["0a:00:00:00:00:01 192.168.1.2"
 ])