diff mbox

[ovs-dev,2/7] ovn: Fix bugs in port security test.

Message ID 1475717212-27467-2-git-send-email-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff Oct. 6, 2016, 1:26 a.m. UTC
A number of instances of "{i}" in this test should have been "${i}".

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 tests/ovn.at | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Gurucharan Shetty Oct. 7, 2016, 2:25 p.m. UTC | #1
On 5 October 2016 at 18:26, Ben Pfaff <blp@ovn.org> wrote:

> A number of instances of "{i}" in this test should have been "${i}".
>
> Signed-off-by: Ben Pfaff <blp@ovn.org>
>
Acked-by: Gurucharan Shetty <guru@ovn.org>

> ---
>  tests/ovn.at | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tests/ovn.at b/tests/ovn.at
> index 05e1349..4214a00 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
> @@ -2626,13 +2626,13 @@ sip=`ip_to_hex 192 168 0 13`
>  tip=`ip_to_hex 192 168 0 23`
>  test_ip 13 f00000000113 f00000000023 $sip $tip
>
> -# ipv6 packet should be received by lp[123]3 with mac f0000000{i}{i}3
> -# and ip6.dst as fe80::ea2a:eaff:fe28:0{i}{i}3.
> +# ipv6 packet should be received by lp[123]3 with mac f00000000${i}${i}3
> +# and ip6.dst as fe80::ea2a:eaff:fe28:0${i}${i}3.
>  # lp11 can send ipv6 traffic as there is no port security
>  sip=ee800000000000000000000000000000
>  for i in 1 2 3; do
> -    tip=fe80000000000000ea2aeafffe2800{i}3
> -    test_ipv6 11 f00000000011 f000000000{i}${i}3 $sip $tip {i}3
> +    tip=fe80000000000000ea2aeafffe2800${i}3
> +    test_ipv6 11 f00000000011 f00000000${i}${i}3 $sip $tip ${i}3
>  done
>
>
> @@ -2645,8 +2645,8 @@ sip=ee800000000000000000000000000000
>  tip=fe80000000000000ea2aeafffe280023
>  test_ipv6 11 f00000000011 f00000000333 $sip $tip
>
> -# ipv6 packet should be allowed for lp[123]3 with mac f0000000{i}{i}3
> -# and ip6.src fe80::ea2a:eaff:fe28:0{i}{i}3 and ip6.src ::.
> +# ipv6 packet should be allowed for lp[123]3 with mac f0000000${i}${i}3
> +# and ip6.src fe80::ea2a:eaff:fe28:0${i}${i}3 and ip6.src ::.
>  # and should be dropped for any other ip6.src
>  # lp21 can receive ipv6 traffic as there is no port security
>
> --
> 2.1.3
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
diff mbox

Patch

diff --git a/tests/ovn.at b/tests/ovn.at
index 05e1349..4214a00 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -2626,13 +2626,13 @@  sip=`ip_to_hex 192 168 0 13`
 tip=`ip_to_hex 192 168 0 23`
 test_ip 13 f00000000113 f00000000023 $sip $tip
 
-# ipv6 packet should be received by lp[123]3 with mac f0000000{i}{i}3
-# and ip6.dst as fe80::ea2a:eaff:fe28:0{i}{i}3.
+# ipv6 packet should be received by lp[123]3 with mac f00000000${i}${i}3
+# and ip6.dst as fe80::ea2a:eaff:fe28:0${i}${i}3.
 # lp11 can send ipv6 traffic as there is no port security
 sip=ee800000000000000000000000000000
 for i in 1 2 3; do
-    tip=fe80000000000000ea2aeafffe2800{i}3
-    test_ipv6 11 f00000000011 f000000000{i}${i}3 $sip $tip {i}3
+    tip=fe80000000000000ea2aeafffe2800${i}3
+    test_ipv6 11 f00000000011 f00000000${i}${i}3 $sip $tip ${i}3
 done
 
 
@@ -2645,8 +2645,8 @@  sip=ee800000000000000000000000000000
 tip=fe80000000000000ea2aeafffe280023
 test_ipv6 11 f00000000011 f00000000333 $sip $tip
 
-# ipv6 packet should be allowed for lp[123]3 with mac f0000000{i}{i}3
-# and ip6.src fe80::ea2a:eaff:fe28:0{i}{i}3 and ip6.src ::.
+# ipv6 packet should be allowed for lp[123]3 with mac f0000000${i}${i}3
+# and ip6.src fe80::ea2a:eaff:fe28:0${i}${i}3 and ip6.src ::.
 # and should be dropped for any other ip6.src
 # lp21 can receive ipv6 traffic as there is no port security