| Message ID | 1475612290-16116-1-git-send-email-aconole@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Oct 04, 2016 at 04:18:10PM -0400, Aaron Conole wrote: > When the read-only infrastucture support was added, the test-suite > registration was missed. This causes tools like valgrind to complain > about uninitialized variable usage. > > Fixes: 1f4a7252d9e7 ("Add read-only option to ovs-dpctl and...") > Cc: Ryan Moats <rmoats@us.ibm.com> > Signed-off-by: Aaron Conole <aconole@redhat.com> > --- > NOTE: I've set this to RO - not sure if RW would be the right thing here? Thanks, applied to master and branch-2.6. I don't think that RO/RW matters since this is for a test program.
diff --git a/tests/ovstest.c b/tests/ovstest.c index 745bd2e..d258232 100644 --- a/tests/ovstest.c +++ b/tests/ovstest.c @@ -101,6 +101,7 @@ ovstest_register(const char *test_name, ovs_cmdl_handler f) test_cmd.min_args = 0; test_cmd.max_args = INT_MAX; test_cmd.handler = f; + test_cmd.mode = OVS_RO; add_command(&test_cmd); }
When the read-only infrastucture support was added, the test-suite registration was missed. This causes tools like valgrind to complain about uninitialized variable usage. Fixes: 1f4a7252d9e7 ("Add read-only option to ovs-dpctl and...") Cc: Ryan Moats <rmoats@us.ibm.com> Signed-off-by: Aaron Conole <aconole@redhat.com> --- NOTE: I've set this to RO - not sure if RW would be the right thing here? tests/ovstest.c | 1 + 1 file changed, 1 insertion(+)