| Message ID | 1473986804-15757-1-git-send-email-rams@vmware.com |
|---|---|
| State | Superseded |
| Headers | show |
Acked-by: Sairam Venugopal <vsairam@vmware.com> On 9/15/16, 5:46 PM, "Shashank Ram" <rams@vmware.com> wrote: >Adds a define for the last defined module number. > >Signed-off-by: Shashank Ram <rams@vmware.com> >--- > datapath-windows/ovsext/Debug.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/datapath-windows/ovsext/Debug.h >b/datapath-windows/ovsext/Debug.h >index 935f858..2175130 100644 >--- a/datapath-windows/ovsext/Debug.h >+++ b/datapath-windows/ovsext/Debug.h >@@ -43,8 +43,9 @@ > #define OVS_DBG_CONTRK BIT32(23) > #define OVS_DBG_GENEVE BIT32(24) > >+#define OVS_DBG_LAST 24 // Set this to the last defined module >number. > #define OVS_DBG_RESERVED BIT32(31) >-//Please add above OVS_DBG_RESERVED. >+//Please add above OVS_DBG_LAST. > > #define OVS_DBG_ERROR DPFLTR_ERROR_LEVEL > #define OVS_DBG_WARN DPFLTR_WARNING_LEVEL >-- >2.6.2 > >_______________________________________________ >dev mailing list >dev@openvswitch.org >https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma >n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dc >ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=XP9lu-Xs-zs4fLi3vm0X_IbhooKFNO >xVKtHCNLxdpv8&s=Hyf2EiQRZ7vNrmjs4k6YVS7WiDuTrIyggzSKkNJ6jf4&e=
Only comment I had was to nuke the OVS_DBG_RESERVED and treat OVS_DBG_LAST itself as the last bit. Basically, we are restricting this to 32 since ŒovsLogLevel¹ is 32 bits. We can probably do: BUILD_ASSERT(OVS_DBG_LAST < 31) BUILD_ASSERT(OVS_DBG_LAST < sizeof ovsLogLevel). Thanks for the cleanup. Thanks, -- Nithin -----Original Message----- From: dev <dev-bounces@openvswitch.org> on behalf of Shashank Ram <rams@vmware.com> Date: Thursday, September 15, 2016 at 5:46 PM To: "dev@openvswitch.org" <dev@openvswitch.org> Cc: Shashank Ram <rams@vmware.com> Subject: [ovs-dev] [PATCH] datapath-windows: Add define for last module number >Adds a define for the last defined module number. > >Signed-off-by: Shashank Ram <rams@vmware.com> >--- > datapath-windows/ovsext/Debug.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/datapath-windows/ovsext/Debug.h >b/datapath-windows/ovsext/Debug.h >index 935f858..2175130 100644 >--- a/datapath-windows/ovsext/Debug.h >+++ b/datapath-windows/ovsext/Debug.h >@@ -43,8 +43,9 @@ > #define OVS_DBG_CONTRK BIT32(23) > #define OVS_DBG_GENEVE BIT32(24) > >+#define OVS_DBG_LAST 24 // Set this to the last defined module >number. > #define OVS_DBG_RESERVED BIT32(31) >-//Please add above OVS_DBG_RESERVED. >+//Please add above OVS_DBG_LAST. > > #define OVS_DBG_ERROR DPFLTR_ERROR_LEVEL > #define OVS_DBG_WARN DPFLTR_WARNING_LEVEL >-- >2.6.2 > >_______________________________________________ >dev mailing list >dev@openvswitch.org >https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma >n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pN >HQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=0pvAR9XWuxljf0K9blx9ZCxughyOW7 >ZxdCZDoaAM8Fs&s=Fy1eCZ44TmWJuBW9BBSsMnkVx4skKLYWOFpK876C7Eg&e=
diff --git a/datapath-windows/ovsext/Debug.h b/datapath-windows/ovsext/Debug.h index 935f858..2175130 100644 --- a/datapath-windows/ovsext/Debug.h +++ b/datapath-windows/ovsext/Debug.h @@ -43,8 +43,9 @@ #define OVS_DBG_CONTRK BIT32(23) #define OVS_DBG_GENEVE BIT32(24) +#define OVS_DBG_LAST 24 // Set this to the last defined module number. #define OVS_DBG_RESERVED BIT32(31) -//Please add above OVS_DBG_RESERVED. +//Please add above OVS_DBG_LAST. #define OVS_DBG_ERROR DPFLTR_ERROR_LEVEL #define OVS_DBG_WARN DPFLTR_WARNING_LEVEL
Adds a define for the last defined module number. Signed-off-by: Shashank Ram <rams@vmware.com> --- datapath-windows/ovsext/Debug.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)