diff mbox

[ovs-dev] datapath-windows: Fix connection state tracking in Conntrack

Message ID 1472497963-2696-1-git-send-email-pboca@cloudbasesolutions.com
State Accepted
Headers show

Commit Message

Paul Boca Aug. 29, 2016, 7:12 p.m. UTC
A connection can be both a reply and related.

Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com>
---
 datapath-windows/ovsext/Conntrack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sairam Venugopal Aug. 29, 2016, 11:19 p.m. UTC | #1
Acked-by: Sairam Venugopal <vsairam@vmware.com>


On 8/29/16, 12:12 PM, "Paul Boca" <pboca@cloudbasesolutions.com> wrote:

>A connection can be both a reply and related.
>
>Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com>
>---
> datapath-windows/ovsext/Conntrack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/datapath-windows/ovsext/Conntrack.c
>b/datapath-windows/ovsext/Conntrack.c
>index af3d966..74fb38c 100644
>--- a/datapath-windows/ovsext/Conntrack.c
>+++ b/datapath-windows/ovsext/Conntrack.c
>@@ -463,7 +463,7 @@ OvsProcessConntrackEntry(PNET_BUFFER_LIST curNbl,
>     if (ctx->related) {
>         state |= OVS_CS_F_RELATED;
>         if (ctx->reply) {
>-            state = OVS_CS_F_REPLY_DIR;
>+            state |= OVS_CS_F_REPLY_DIR;
>         }
>     } else {
>         CT_UPDATE_RES result;
>-- 
>2.7.2.windows.1
>_______________________________________________
>dev mailing list
>dev@openvswitch.org
>https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma
>n_listinfo_dev&d=CwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dc
>ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=3qBj3ok5m-dA2AcBo768s343DUvPOx
>ZQsNPC9vg6mnQ&s=5cOBvbwZt9fQb1GOeaZVxNRhU8_5LYOf3MFOaqTLoME&e=
diff mbox

Patch

diff --git a/datapath-windows/ovsext/Conntrack.c b/datapath-windows/ovsext/Conntrack.c
index af3d966..74fb38c 100644
--- a/datapath-windows/ovsext/Conntrack.c
+++ b/datapath-windows/ovsext/Conntrack.c
@@ -463,7 +463,7 @@  OvsProcessConntrackEntry(PNET_BUFFER_LIST curNbl,
     if (ctx->related) {
         state |= OVS_CS_F_RELATED;
         if (ctx->reply) {
-            state = OVS_CS_F_REPLY_DIR;
+            state |= OVS_CS_F_REPLY_DIR;
         }
     } else {
         CT_UPDATE_RES result;