| Message ID | 1471890809-4383-39-git-send-email-mikko.rapeli@iki.fi |
|---|---|
| State | Not Applicable |
| Headers | show |
On Mon, 22 Aug 2016 20:32:55 +0200 Mikko Rapeli <mikko.rapeli@iki.fi> wrote: > Fixes userspace compiler error: > > error: unknown type name ‘uint32_t’ > > Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi> > --- > include/uapi/linux/openvswitch.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h > index d95a301..645499a 100644 > --- a/include/uapi/linux/openvswitch.h > +++ b/include/uapi/linux/openvswitch.h > @@ -632,8 +632,8 @@ enum ovs_hash_alg { > * @hash_basis: basis used for computing hash. > */ > struct ovs_action_hash { > - uint32_t hash_alg; /* One of ovs_hash_alg. */ > - uint32_t hash_basis; > + __u32 hash_alg; /* One of ovs_hash_alg. */ > + __u32 hash_basis; > }; > > /** This is a a real issue, but being buried in a huge patch series of include file stuff I don't think anyone would see it.
From: Stephen Hemminger <stephen@networkplumber.org> Date: Mon, 22 Aug 2016 12:39:38 -0700 > This is a a real issue, but being buried in a huge patch series of include > file stuff I don't think anyone would see it. It hit netdev and thus patchwork, therefore anyone watching networking patches saw it. I would not call it buried at all.
From: Mikko Rapeli <mikko.rapeli@iki.fi> Date: Mon, 22 Aug 2016 20:32:55 +0200 > Fixes userspace compiler error: > > error: unknown type name ‘uint32_t’ > > Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi> Applied.
On Mon, Aug 22, 2016 at 12:39:38PM -0700, Stephen Hemminger wrote: > On Mon, 22 Aug 2016 20:32:55 +0200 > Mikko Rapeli <mikko.rapeli@iki.fi> wrote: > > > Fixes userspace compiler error: > > > > error: unknown type name ‘uint32_t’ > > > > Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi> > > --- > > include/uapi/linux/openvswitch.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h > > index d95a301..645499a 100644 > > --- a/include/uapi/linux/openvswitch.h > > +++ b/include/uapi/linux/openvswitch.h > > @@ -632,8 +632,8 @@ enum ovs_hash_alg { > > * @hash_basis: basis used for computing hash. > > */ > > struct ovs_action_hash { > > - uint32_t hash_alg; /* One of ovs_hash_alg. */ > > - uint32_t hash_basis; > > + __u32 hash_alg; /* One of ovs_hash_alg. */ > > + __u32 hash_basis; > > }; > > > > /** > > This is a a real issue, but being buried in a huge patch series of include > file stuff I don't think anyone would see it. The mechanism for finding this issue the same as finding a missing header file dependency: the uapi header userspace compile test. https://lkml.org/lkml/2016/8/22/659 I'm using "scripts/get_maintainers.pl --no-rolestats" to fill in the Cc: list for git send-email so if MAINTAINERS is uptodate, then correct lists and maintainers should have the received the patches. -Mikko
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h index d95a301..645499a 100644 --- a/include/uapi/linux/openvswitch.h +++ b/include/uapi/linux/openvswitch.h @@ -632,8 +632,8 @@ enum ovs_hash_alg { * @hash_basis: basis used for computing hash. */ struct ovs_action_hash { - uint32_t hash_alg; /* One of ovs_hash_alg. */ - uint32_t hash_basis; + __u32 hash_alg; /* One of ovs_hash_alg. */ + __u32 hash_basis; }; /**
Fixes userspace compiler error: error: unknown type name ‘uint32_t’ Signed-off-by: Mikko Rapeli <mikko.rapeli@iki.fi> --- include/uapi/linux/openvswitch.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)