diff mbox

[ovs-dev,04/30] packets: Improve comment on eth_addr_from_string().

Message ID 1470642309-18995-5-git-send-email-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff Aug. 8, 2016, 7:44 a.m. UTC
Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 lib/packets.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ryan Moats Aug. 8, 2016, 3:15 p.m. UTC | #1
"dev" <dev-bounces@openvswitch.org> wrote on 08/08/2016 02:44:43 AM:

> From: Ben Pfaff <blp@ovn.org>
> To: dev@openvswitch.org
> Cc: Ben Pfaff <blp@ovn.org>
> Date: 08/08/2016 02:46 AM
> Subject: [ovs-dev] [PATCH 04/30] packets: Improve comment on
> eth_addr_from_string().
> Sent by: "dev" <dev-bounces@openvswitch.org>
>
> Signed-off-by: Ben Pfaff <blp@ovn.org>
> ---
>  lib/packets.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lib/packets.c b/lib/packets.c
> index d1e2a70..e4c29d5 100644
> --- a/lib/packets.c
> +++ b/lib/packets.c
> @@ -140,6 +140,9 @@ eth_addr_is_reserved(const struct eth_addr ea)
>      return false;
>  }
>
> +/* Attempts to parse 's' as an Ethernet address.  If successful, stores
the
> + * address in 'ea' and returns true, otherwise zeros 'ea' and returns
> + * false.  */
>  bool
>  eth_addr_from_string(const char *s, struct eth_addr *ea)
>  {

Same comment as with PS3...

Acked-by: Ryan Moats <rmoats@us.ibm.com>
diff mbox

Patch

diff --git a/lib/packets.c b/lib/packets.c
index d1e2a70..e4c29d5 100644
--- a/lib/packets.c
+++ b/lib/packets.c
@@ -140,6 +140,9 @@  eth_addr_is_reserved(const struct eth_addr ea)
     return false;
 }
 
+/* Attempts to parse 's' as an Ethernet address.  If successful, stores the
+ * address in 'ea' and returns true, otherwise zeros 'ea' and returns
+ * false.  */
 bool
 eth_addr_from_string(const char *s, struct eth_addr *ea)
 {