diff mbox

[ovs-dev,03/30] flow: Comment that nw_src holds ARP SPA and nw_dst holds ARP TPA.

Message ID 1470642309-18995-4-git-send-email-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff Aug. 8, 2016, 7:44 a.m. UTC
Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 include/openvswitch/flow.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ryan Moats Aug. 8, 2016, 3:14 p.m. UTC | #1
"dev" <dev-bounces@openvswitch.org> wrote on 08/08/2016 02:44:42 AM:

> From: Ben Pfaff <blp@ovn.org>
> To: dev@openvswitch.org
> Cc: Ben Pfaff <blp@ovn.org>
> Date: 08/08/2016 02:45 AM
> Subject: [ovs-dev] [PATCH 03/30] flow: Comment that nw_src holds ARP
> SPA and nw_dst holds ARP TPA.
> Sent by: "dev" <dev-bounces@openvswitch.org>
>
> Signed-off-by: Ben Pfaff <blp@ovn.org>
> ---
>  include/openvswitch/flow.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/openvswitch/flow.h b/include/openvswitch/flow.h
> index 6b3005b..df80dfe 100644
> --- a/include/openvswitch/flow.h
> +++ b/include/openvswitch/flow.h
> @@ -107,8 +107,8 @@ struct flow {
>      ovs_be32 mpls_lse[ROUND_UP(FLOW_MAX_MPLS_LABELS, 2)]; /* MPLS label
stack
>                                                               (with
> padding). */
>      /* L3 (64-bit aligned) */
> -    ovs_be32 nw_src;            /* IPv4 source address. */
> -    ovs_be32 nw_dst;            /* IPv4 destination address. */
> +    ovs_be32 nw_src;            /* IPv4 source address or ARP SPA. */
> +    ovs_be32 nw_dst;            /* IPv4 destination address or ARP TPA.
*/
>      struct in6_addr ipv6_src;   /* IPv6 source address. */
>      struct in6_addr ipv6_dst;   /* IPv6 destination address. */
>      ovs_be32 ipv6_label;        /* IPv6 flow label. */
> --

Since it's a comment change, the only thing to check is whether it
applies cleanly or not... since it does...

Acked-by: Ryan Moats <rmoats@us.ibm.com>
diff mbox

Patch

diff --git a/include/openvswitch/flow.h b/include/openvswitch/flow.h
index 6b3005b..df80dfe 100644
--- a/include/openvswitch/flow.h
+++ b/include/openvswitch/flow.h
@@ -107,8 +107,8 @@  struct flow {
     ovs_be32 mpls_lse[ROUND_UP(FLOW_MAX_MPLS_LABELS, 2)]; /* MPLS label stack
                                                              (with padding). */
     /* L3 (64-bit aligned) */
-    ovs_be32 nw_src;            /* IPv4 source address. */
-    ovs_be32 nw_dst;            /* IPv4 destination address. */
+    ovs_be32 nw_src;            /* IPv4 source address or ARP SPA. */
+    ovs_be32 nw_dst;            /* IPv4 destination address or ARP TPA. */
     struct in6_addr ipv6_src;   /* IPv6 source address. */
     struct in6_addr ipv6_dst;   /* IPv6 destination address. */
     ovs_be32 ipv6_label;        /* IPv6 flow label. */