From patchwork Fri Jul 29 08:07:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 654024 X-Patchwork-Delegate: diproiettod@vmware.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3s11YM48Kzz9t0G for ; Fri, 29 Jul 2016 18:07:35 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 1462B114B2; Fri, 29 Jul 2016 01:07:34 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id D23BC114A9 for ; Fri, 29 Jul 2016 01:07:32 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id 69C8F161033 for ; Fri, 29 Jul 2016 02:07:32 -0600 (MDT) X-ASG-Debug-ID: 1469779650-0b32374773394b50001-byXFYA Received: from mx1-pf1.cudamail.com ([192.168.24.1]) by bar6.cudamail.com with ESMTP id roy9IQqBaUaRy0Yb (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 29 Jul 2016 02:07:30 -0600 (MDT) X-Barracuda-Envelope-From: i.maximets@samsung.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.24.1 Received: from unknown (HELO mailout1.w1.samsung.com) (210.118.77.11) by mx1-pf1.cudamail.com with ESMTPS (DHE-RSA-AES128-SHA encrypted); 29 Jul 2016 08:07:30 -0000 Received-SPF: none (mx1-pf1.cudamail.com: domain at samsung.com does not designate permitted sender hosts) X-Barracuda-Apparent-Source-IP: 210.118.77.11 X-Barracuda-RBL-IP: 210.118.77.11 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OB20004IH8FJP40@mailout1.w1.samsung.com> for dev@openvswitch.org; Fri, 29 Jul 2016 09:07:27 +0100 (BST) X-AuditID: cbfec7f4-f796c6d000001486-98-579b0ebfb3e8 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 0B.4F.05254.FBE0B975; Fri, 29 Jul 2016 09:07:27 +0100 (BST) Received: from imaximets.rnd.samsung.ru ([106.109.129.180]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OB200CCLH8BO740@eusync3.samsung.com>; Fri, 29 Jul 2016 09:07:27 +0100 (BST) X-CudaMail-Envelope-Sender: i.maximets@samsung.com From: Ilya Maximets To: dev@openvswitch.org, Daniele Di Proietto X-CudaMail-MID: CM-E1-728001867 X-CudaMail-DTE: 072916 X-CudaMail-Originating-IP: 210.118.77.11 Date: Fri, 29 Jul 2016 11:07:21 +0300 X-ASG-Orig-Subj: [##CM-E1-728001867##][PATCH] dpif-netdev: Fix xps revalidation. Message-id: <1469779641-26279-1-git-send-email-i.maximets@samsung.com> X-Mailer: git-send-email 2.7.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOJMWRmVeSWpSXmKPExsVy+t/xq7r7+WaHGzS2SVscPb2H2eJl9z12 i2mfb7NbXGn/yW4xebaUA6vHs5v/GT36tqxi9Hg3/y1bAHMUl01Kak5mWWqRvl0CV8b1LxPY Cv6yVvx98pu9gfEmSxcjJ4eEgInE4+vfoGwxiQv31rN1MXJxCAksZZSYOucLK4TTyiRx9sAF ZpAqNgEdiVOrjzCC2CICrhLTb79hB7GZBSolWr6cAbOFBYwlmjqawOpZBFQlFj16CLSBg4NX wE3izEl7iGVyEjfPdTJPYORewMiwilE0tTS5oDgpPddQrzgxt7g0L10vOT93EyPE+192MC4+ ZnWIUYCDUYmH96PsrHAh1sSy4srcQ4wSHMxKIrx5XLPDhXhTEiurUovy44tKc1KLDzFKc7Ao ifPO3fU+REggPbEkNTs1tSC1CCbLxMEp1cDYc/NB/h+BPaEMpQv8eSTP7GCf13Vb8srW1n+K 6yOz1qlqv9M2viw+wecjl6w4b9w3qc9znl64af7tft4/foNJR9xOcu2Rn/sj+P5z0+6Vj/X2 xvXd/6bPMln21KYpMqeiX83vn7/m2fF718vM81d5TxBx9Nu7ykO9eeHlmPM7I3cJ9CvvEVVR UWIpzkg01GIuKk4EAHbH+Eb6AQAA X-Barracuda-Connect: UNKNOWN[192.168.24.1] X-Barracuda-Start-Time: 1469779650 X-Barracuda-Encrypted: ECDHE-RSA-AES256-GCM-SHA384 X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-ASG-Whitelist: EmailCat (corporate) Cc: Ilya Maximets , Dyasly Sergey Subject: [ovs-dev] [PATCH] dpif-netdev: Fix xps revalidation. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" Revalidation should work in case of 'dynamic_txqs == true'. Fixes: 324c8374852a ("dpif-netdev: XPS (Transmit Packet Steering) implementation.") Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 828171e..c446ae8 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4193,7 +4193,7 @@ dpif_netdev_xps_revalidate_pmd(const struct dp_netdev_pmd_thread *pmd, long long interval; HMAP_FOR_EACH (tx, node, &pmd->port_cache) { - if (tx->port->dynamic_txqs) { + if (!tx->port->dynamic_txqs) { continue; } interval = now - tx->last_used;