From patchwork Tue Jul 26 12:03:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Boca X-Patchwork-Id: 652739 X-Patchwork-Delegate: guru@ovn.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3rzH1023hqz9s2Q for ; Tue, 26 Jul 2016 22:07:00 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 3919610B97; Tue, 26 Jul 2016 05:06:58 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx1e4.cudamail.com (mx1.cudamail.com [69.90.118.67]) by archives.nicira.com (Postfix) with ESMTPS id 2019910B96 for ; Tue, 26 Jul 2016 05:06:57 -0700 (PDT) Received: from bar5.cudamail.com (unknown [192.168.21.12]) by mx1e4.cudamail.com (Postfix) with ESMTPS id A628E1E03B0 for ; Tue, 26 Jul 2016 06:06:56 -0600 (MDT) X-ASG-Debug-ID: 1469534814-09eadd464958f070001-byXFYA Received: from mx3-pf3.cudamail.com ([192.168.14.3]) by bar5.cudamail.com with ESMTP id e2dnPJN54nUMiHBF (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 26 Jul 2016 06:06:54 -0600 (MDT) X-Barracuda-Envelope-From: pboca@cloudbasesolutions.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.3 Received: from unknown (HELO cbssmtp1.cloudbase.local) (91.232.152.5) by mx3-pf3.cudamail.com with SMTP; 26 Jul 2016 12:06:53 -0000 Received-SPF: pass (mx3-pf3.cudamail.com: SPF record at cloudbasesolutions.com designates 91.232.152.5 as permitted sender) X-Barracuda-Apparent-Source-IP: 91.232.152.5 X-Barracuda-RBL-IP: 91.232.152.5 Received: from localhost (localhost [127.0.0.1]) by cbssmtp1.cloudbase.local (Postfix) with ESMTP id 2F0AA406BA for ; Tue, 26 Jul 2016 15:06:52 +0300 (EEST) X-Virus-Scanned: amavisd-new at cloudbasesolutions.com Received: from cbssmtp1.cloudbase.local ([127.0.0.1]) by localhost (cbssmtp1.cloudbase.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IgnpL6geVTT1 for ; Tue, 26 Jul 2016 15:06:32 +0300 (EEST) Received: from CBSEX1.cloudbase.local (unknown [10.77.78.3]) by cbssmtp1.cloudbase.local (Postfix) with ESMTP id 525ED405A5 for ; Tue, 26 Jul 2016 15:03:17 +0300 (EEST) Received: from CBSEX1.cloudbase.local ([10.77.78.3]) by CBSEX1.cloudbase.local ([10.77.78.3]) with mapi id 14.03.0301.000; Tue, 26 Jul 2016 14:03:17 +0200 X-CudaMail-Envelope-Sender: pboca@cloudbasesolutions.com From: Paul Boca To: "dev@openvswitch.org" X-CudaMail-MID: CM-V3-725006547 X-CudaMail-DTE: 072616 X-CudaMail-Originating-IP: 91.232.152.5 Thread-Topic: [PATCH V9 17/17] tests: Skip vlog tests that try to move opened file X-ASG-Orig-Subj: [##CM-V3-725006547##][PATCH V9 17/17] tests: Skip vlog tests that try to move opened file Thread-Index: AQHR5zWxhnBpPL/Op0GYJrSpO7MSKw== Date: Tue, 26 Jul 2016 12:03:16 +0000 Message-ID: <1469534595-5832-1-git-send-email-pboca@cloudbasesolutions.com> Accept-Language: en-US, it-IT Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.77.78.1] MIME-Version: 1.0 X-GBUdb-Analysis: 0, 91.232.152.5, Ugly c=0.377531 p=-0.487179 Source Normal X-MessageSniffer-Rules: 0-0-0-3903-c X-Barracuda-Connect: UNKNOWN[192.168.14.3] X-Barracuda-Start-Time: 1469534814 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.10 X-Barracuda-Spam-Status: No, SCORE=0.10 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.0 tests=RDNS_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.31531 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS Subject: [ovs-dev] [PATCH V9 17/17] tests: Skip vlog tests that try to move opened file X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@openvswitch.org Sender: "dev" On Windows if a file is opened by an application for writing, we cannot move it until all handles to that file are closed. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: Removed code that disables 'vlog/close' tests. V7: Small comments changes V8: No changes V9: No changes --- tests/vlog.at | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/vlog.at b/tests/vlog.at index 4907a1b..468e872 100644 --- a/tests/vlog.at +++ b/tests/vlog.at @@ -148,6 +148,9 @@ AT_CLEANUP m4_define([VLOG_REOPEN_PYN], [AT_SETUP([vlog - vlog/reopen - $1]) + # This test won't work as-is on Windows because Windows doesn't allow + # files that are open to be renamed. + AT_SKIP_IF([test "$IS_WIN32" = "yes"]) AT_SKIP_IF([test $2 = no]) on_exit 'kill `cat test-unixctl.py.pid`'