diff mbox

[ovs-dev,5/5] ofp-actions: Remove XXX comment for write-actions in ofpacts_format().

Message ID 1468454768-10085-6-git-send-email-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff July 14, 2016, 12:06 a.m. UTC
I don't know why this was here.  The write_actions instruction works fine.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 lib/ofp-actions.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jarno Rajahalme July 14, 2016, 10:05 a.m. UTC | #1
Does not ring a bell either!

Acked-by: Jarno Rajahalme <jarno@ovn.org>

> On Jul 13, 2016, at 5:06 PM, Ben Pfaff <blp@ovn.org> wrote:
> 
> I don't know why this was here.  The write_actions instruction works fine.
> 
> Signed-off-by: Ben Pfaff <blp@ovn.org>
> ---
> lib/ofp-actions.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
> index aa681c0..8e41f7c 100644
> --- a/lib/ofp-actions.c
> +++ b/lib/ofp-actions.c
> @@ -7632,7 +7632,6 @@ ofpacts_format(const struct ofpact *ofpacts, size_t ofpacts_len,
>                 ds_put_char(string, ',');
>             }
> 
> -            /* XXX write-actions */
>             ofpact_format(a, string);
>         }
>     }
> -- 
> 2.1.3
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
Ben Pfaff July 14, 2016, 3:45 p.m. UTC | #2
Thanks for all the reviews.  I applied the series.

On Thu, Jul 14, 2016 at 03:05:22AM -0700, Jarno Rajahalme wrote:
> Does not ring a bell either!
> 
> Acked-by: Jarno Rajahalme <jarno@ovn.org>
> 
> > On Jul 13, 2016, at 5:06 PM, Ben Pfaff <blp@ovn.org> wrote:
> > 
> > I don't know why this was here.  The write_actions instruction works fine.
> > 
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> > ---
> > lib/ofp-actions.c | 1 -
> > 1 file changed, 1 deletion(-)
> > 
> > diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
> > index aa681c0..8e41f7c 100644
> > --- a/lib/ofp-actions.c
> > +++ b/lib/ofp-actions.c
> > @@ -7632,7 +7632,6 @@ ofpacts_format(const struct ofpact *ofpacts, size_t ofpacts_len,
> >                 ds_put_char(string, ',');
> >             }
> > 
> > -            /* XXX write-actions */
> >             ofpact_format(a, string);
> >         }
> >     }
> > -- 
> > 2.1.3
> > 
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
>
diff mbox

Patch

diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index aa681c0..8e41f7c 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -7632,7 +7632,6 @@  ofpacts_format(const struct ofpact *ofpacts, size_t ofpacts_len,
                 ds_put_char(string, ',');
             }
 
-            /* XXX write-actions */
             ofpact_format(a, string);
         }
     }