From patchwork Wed Jul 6 12:38:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Boca X-Patchwork-Id: 645284 X-Patchwork-Delegate: guru@ovn.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3rl0kF3Fg1z9sRZ for ; Wed, 6 Jul 2016 22:41:41 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id B5CF422C416; Wed, 6 Jul 2016 05:41:40 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id 7066B22C416 for ; Wed, 6 Jul 2016 05:41:39 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id F27BD162172 for ; Wed, 6 Jul 2016 06:41:38 -0600 (MDT) X-ASG-Debug-ID: 1467808897-0b32370668102870001-byXFYA Received: from mx3-pf3.cudamail.com ([192.168.14.3]) by bar6.cudamail.com with ESMTP id jC2vghffHoL9WckI (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 06 Jul 2016 06:41:37 -0600 (MDT) X-Barracuda-Envelope-From: pboca@cloudbasesolutions.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.3 Received: from unknown (HELO cbssmtp1.cloudbase.local) (91.232.152.5) by mx3-pf3.cudamail.com with SMTP; 6 Jul 2016 12:41:36 -0000 Received-SPF: pass (mx3-pf3.cudamail.com: SPF record at cloudbasesolutions.com designates 91.232.152.5 as permitted sender) X-Barracuda-Apparent-Source-IP: 91.232.152.5 X-Barracuda-RBL-IP: 91.232.152.5 Received: from localhost (localhost [127.0.0.1]) by cbssmtp1.cloudbase.local (Postfix) with ESMTP id BB2F5417AB for ; Wed, 6 Jul 2016 15:41:35 +0300 (EEST) X-Virus-Scanned: amavisd-new at cloudbasesolutions.com Received: from cbssmtp1.cloudbase.local ([127.0.0.1]) by localhost (cbssmtp1.cloudbase.local [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KF4FWn1YYupC for ; Wed, 6 Jul 2016 15:41:15 +0300 (EEST) Received: from CBSEX1.cloudbase.local (unknown [10.77.78.3]) by cbssmtp1.cloudbase.local (Postfix) with ESMTP id 9FAF1402A8 for ; Wed, 6 Jul 2016 15:38:32 +0300 (EEST) Received: from CBSEX1.cloudbase.local ([10.77.78.3]) by CBSEX1.cloudbase.local ([10.77.78.3]) with mapi id 14.03.0301.000; Wed, 6 Jul 2016 14:38:32 +0200 X-CudaMail-Envelope-Sender: pboca@cloudbasesolutions.com From: Paul Boca To: "dev@openvswitch.org" X-CudaMail-MID: CM-V3-705008163 X-CudaMail-DTE: 070616 X-CudaMail-Originating-IP: 91.232.152.5 Thread-Topic: [PATCH V6 16/17] tests: Skip vlog tests that try to move opened file X-ASG-Orig-Subj: [##CM-V3-705008163##][PATCH V6 16/17] tests: Skip vlog tests that try to move opened file Thread-Index: AQHR14NNPHSLf4FvtUWNLUpnBHdaiA== Date: Wed, 6 Jul 2016 12:38:31 +0000 Message-ID: <1467808691-17280-17-git-send-email-pboca@cloudbasesolutions.com> References: <1467808691-17280-1-git-send-email-pboca@cloudbasesolutions.com> In-Reply-To: <1467808691-17280-1-git-send-email-pboca@cloudbasesolutions.com> Accept-Language: en-US, it-IT Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.77.78.1] MIME-Version: 1.0 X-GBUdb-Analysis: 0, 91.232.152.5, Ugly c=0.369283 p=-0.388889 Source Normal X-MessageSniffer-Rules: 0-0-0-5100-c X-Barracuda-Connect: UNKNOWN[192.168.14.3] X-Barracuda-Start-Time: 1467808897 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.10 X-Barracuda-Spam-Status: No, SCORE=0.10 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.0 tests=RDNS_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.31058 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS Subject: [ovs-dev] [PATCH V6 16/17] tests: Skip vlog tests that try to move opened file X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@openvswitch.org Sender: "dev" On Windows if a file is opened by an application for writing, we cannot move it until all handles to that file are closed. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: Removed code that disables 'vlog/close' tests. --- tests/vlog.at | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/vlog.at b/tests/vlog.at index 3a3d435..7f3004d 100644 --- a/tests/vlog.at +++ b/tests/vlog.at @@ -115,6 +115,9 @@ m4_divert_pop([PREPARE_TESTS]) AT_SETUP([vlog - vlog/reopen - C]) # This test won't work as-is on Windows because Windows doesn't allow # files that are open to be renamed. +# Also, on Windows it is not possible to initiate move file operation +# while it is opened, and when the file is closed to expect it is +# also removed, like on Linux. AT_SKIP_IF([test "$IS_WIN32" = "yes"]) on_exit 'kill `cat test-unixctl.pid`' @@ -148,6 +151,12 @@ AT_CLEANUP m4_define([VLOG_REOPEN_PYN], [AT_SETUP([vlog - vlog/reopen - $1]) + # This test won't work as-is on Windows because Windows doesn't allow + # files that are open to be renamed. + # Also, on Windows it is not possible to initiate move file operation + # while it is opened, and when the file is closed to expect it is + # also removed, like on Linux. + AT_SKIP_IF([test "$IS_WIN32" = "yes"]) AT_SKIP_IF([test $2 = no]) on_exit 'kill `cat test-unixctl.py.pid`'