| Message ID | 1465395390-6372-1-git-send-email-aserdean@cloudbasesolutions.com |
|---|---|
| State | Deferred |
| Headers | show |
On Wed, Jun 08, 2016 at 02:16:28PM +0000, Alin Serdean wrote: > This patch removes the code which disables Python tests to be run on > Windows. > > Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> Do the Python tests pass on Windows now, then?
ERROR: 225 tests were run, 59 failed (1 expected failure). 226 tests were skipped. Result given by running only the python tests. Paul will add more patches on top of this one to fix the failures. I can send this patch later on, after all his patches get integrated on top of master. Alin. > -----Mesaj original----- > De la: Ben Pfaff [mailto:blp@ovn.org] > Trimis: Wednesday, June 8, 2016 6:07 PM > Către: Alin Serdean <aserdean@cloudbasesolutions.com> > Cc: dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] at tests: Allow Python tests to be run on > Windows > > On Wed, Jun 08, 2016 at 02:16:28PM +0000, Alin Serdean wrote: > > This patch removes the code which disables Python tests to be run on > > Windows. > > > > Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > > Do the Python tests pass on Windows now, then?
Our usual practice would be to fix the test failures before enabling the tests; this could for example be the final patch in a series that fixes them. On Wed, Jun 08, 2016 at 03:31:06PM +0000, Alin Serdean wrote: > ERROR: 225 tests were run, > 59 failed (1 expected failure). > 226 tests were skipped. > > Result given by running only the python tests. > > Paul will add more patches on top of this one to fix the failures. > > I can send this patch later on, after all his patches get integrated on top of master. > > Alin. > > > -----Mesaj original----- > > De la: Ben Pfaff [mailto:blp@ovn.org] > > Trimis: Wednesday, June 8, 2016 6:07 PM > > Către: Alin Serdean <aserdean@cloudbasesolutions.com> > > Cc: dev@openvswitch.org > > Subiect: Re: [ovs-dev] [PATCH] at tests: Allow Python tests to be run on > > Windows > > > > On Wed, Jun 08, 2016 at 02:16:28PM +0000, Alin Serdean wrote: > > > This patch removes the code which disables Python tests to be run on > > > Windows. > > > > > > Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > > > > Do the Python tests pass on Windows now, then?
diff --git a/tests/atlocal.in b/tests/atlocal.in index f174061..410199f 100644 --- a/tests/atlocal.in +++ b/tests/atlocal.in @@ -109,13 +109,6 @@ else HAVE_IPV6=no fi -# XXX: Disable Python related tests on Windows because Open vSwitch code -# written in Python has not been ported to the Windows platform. We will -# need to remove the next block after porting is complete. -if test "$IS_WIN32" = "yes"; then - HAVE_PYTHON="no" -fi - if test "$HAVE_PYTHON" = "yes" \ && test "x`$PYTHON $abs_top_srcdir/tests/test-l7.py --help | grep 'ftp'`" != x; then HAVE_PYFTPDLIB="yes"
This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> --- tests/atlocal.in | 7 ------- 1 file changed, 7 deletions(-)