diff mbox

[ovs-dev,2/2] tests: Fixed access denied on ovs-vswitchd.log

Message ID 1464696587-16652-2-git-send-email-pboca@cloudbasesolutions.com
State Not Applicable
Headers show

Commit Message

Paul Boca May 31, 2016, 12:10 p.m. UTC
On Windows trying to overwrite the opened ovs-vswitchd.log
fails with access denied. Closing it before trying to overwrite it
solves the problem

Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com>
---
 tests/ofproto-dpif.at | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Paul Boca May 31, 2016, 7:34 p.m. UTC | #1
Ignore this one, I will send a V2.

> -----Original Message-----

> From: dev [mailto:dev-bounces@openvswitch.org] On Behalf Of Paul Boca

> Sent: Tuesday, May 31, 2016 3:11 PM

> To: dev@openvswitch.org

> Subject: [ovs-dev] [PATCH 2/2] tests: Fixed access denied on ovs-vswitchd.log

> 

> On Windows trying to overwrite the opened ovs-vswitchd.log

> fails with access denied. Closing it before trying to overwrite it

> solves the problem

> 

> Signed-off-by: Paul-Daniel Boca <pboca@cloudbasesolutions.com>

> ---

>  tests/ofproto-dpif.at | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at

> index bf9cf88..5eab12d 100644

> --- a/tests/ofproto-dpif.at

> +++ b/tests/ofproto-dpif.at

> @@ -6923,7 +6923,7 @@ OVS_WAIT_UNTIL([grep "monitor thread created"

> ovs-vswitchd.log])

>  AT_CHECK([ovs-vsctl set interface p0 bfd:enable=false])

>  # check log.

>  OVS_WAIT_UNTIL([grep "monitor thread terminated" ovs-vswitchd.log])

> -AT_CHECK([sed -e '/^.*ofproto_dpif_monitor.*$/d' < ovs-vswitchd.log > tmp

> && mv tmp ovs-vswitchd.log && ovs-appctl vlog/reopen])

> +AT_CHECK([sed -e '/^.*ofproto_dpif_monitor.*$/d' < ovs-vswitchd.log > tmp

> && ovs-appctl.exe vlog/close && mv tmp ovs-vswitchd.log && ovs-appctl

> vlog/reopen])

> 

>  # enable cfm on p0.

>  AT_CHECK([ovs-vsctl set interface p0 cfm_mpid=10])

> @@ -6933,7 +6933,7 @@ OVS_WAIT_UNTIL([grep "monitor thread created"

> ovs-vswitchd.log])

>  AT_CHECK([ovs-vsctl remove interface p0 cfm_mpid 10])

>  # check log.

>  OVS_WAIT_UNTIL([grep "monitor thread terminated" ovs-vswitchd.log])

> -AT_CHECK([sed -e '/^.*ofproto_dpif_monitor.*$/d' < ovs-vswitchd.log > tmp

> && mv tmp ovs-vswitchd.log && ovs-appctl vlog/reopen])

> +AT_CHECK([sed -e '/^.*ofproto_dpif_monitor.*$/d' < ovs-vswitchd.log > tmp

> && ovs-appctl.exe vlog/close && mv tmp ovs-vswitchd.log && ovs-appctl

> vlog/reopen])

> 

>  # enable both bfd and cfm on p0.

>  AT_CHECK([ovs-vsctl set interface p0 bfd:enable=true cfm_mpid=10])

> --

> 2.7.2.windows.1

> _______________________________________________

> dev mailing list

> dev@openvswitch.org

> http://openvswitch.org/mailman/listinfo/dev
diff mbox

Patch

diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at
index bf9cf88..5eab12d 100644
--- a/tests/ofproto-dpif.at
+++ b/tests/ofproto-dpif.at
@@ -6923,7 +6923,7 @@  OVS_WAIT_UNTIL([grep "monitor thread created" ovs-vswitchd.log])
 AT_CHECK([ovs-vsctl set interface p0 bfd:enable=false])
 # check log.
 OVS_WAIT_UNTIL([grep "monitor thread terminated" ovs-vswitchd.log])
-AT_CHECK([sed -e '/^.*ofproto_dpif_monitor.*$/d' < ovs-vswitchd.log > tmp && mv tmp ovs-vswitchd.log && ovs-appctl vlog/reopen])
+AT_CHECK([sed -e '/^.*ofproto_dpif_monitor.*$/d' < ovs-vswitchd.log > tmp && ovs-appctl.exe vlog/close && mv tmp ovs-vswitchd.log && ovs-appctl vlog/reopen])
 
 # enable cfm on p0.
 AT_CHECK([ovs-vsctl set interface p0 cfm_mpid=10])
@@ -6933,7 +6933,7 @@  OVS_WAIT_UNTIL([grep "monitor thread created" ovs-vswitchd.log])
 AT_CHECK([ovs-vsctl remove interface p0 cfm_mpid 10])
 # check log.
 OVS_WAIT_UNTIL([grep "monitor thread terminated" ovs-vswitchd.log])
-AT_CHECK([sed -e '/^.*ofproto_dpif_monitor.*$/d' < ovs-vswitchd.log > tmp && mv tmp ovs-vswitchd.log && ovs-appctl vlog/reopen])
+AT_CHECK([sed -e '/^.*ofproto_dpif_monitor.*$/d' < ovs-vswitchd.log > tmp && ovs-appctl.exe vlog/close && mv tmp ovs-vswitchd.log && ovs-appctl vlog/reopen])
 
 # enable both bfd and cfm on p0.
 AT_CHECK([ovs-vsctl set interface p0 bfd:enable=true cfm_mpid=10])