From patchwork Fri May 13 17:33:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 622095 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3r5xlg6Tmkz9t5x for ; Sat, 14 May 2016 03:33:19 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=njrvSmX/; dkim-atps=neutral Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 11EDE10AB3; Fri, 13 May 2016 10:33:17 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id 824EB10AAE for ; Fri, 13 May 2016 10:33:15 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id F169A1621FC for ; Fri, 13 May 2016 11:33:14 -0600 (MDT) X-ASG-Debug-ID: 1463160794-0b32370aa8171a10001-byXFYA Received: from mx3-pf2.cudamail.com ([192.168.14.1]) by bar6.cudamail.com with ESMTP id u40KAxJQ0ceSRO0Q (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 13 May 2016 11:33:14 -0600 (MDT) X-Barracuda-Envelope-From: u9012063@gmail.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.1 Received: from unknown (HELO mail-pf0-f196.google.com) (209.85.192.196) by mx3-pf2.cudamail.com with ESMTPS (RC4-SHA encrypted); 13 May 2016 17:33:14 -0000 Received-SPF: pass (mx3-pf2.cudamail.com: SPF record at _netblocks.google.com designates 209.85.192.196 as permitted sender) X-Barracuda-Apparent-Source-IP: 209.85.192.196 X-Barracuda-RBL-IP: 209.85.192.196 Received: by mail-pf0-f196.google.com with SMTP id g132so9782074pfb.3 for ; Fri, 13 May 2016 10:33:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id; bh=UC/EoX03ceQZeX9QVLAiKEvcDFmh8FIGe76XPutT7dU=; b=njrvSmX/tNtK63IjOkpRXOQCmM2Vc8jZgraV2H8PxgpXfs+Dg63DsKWYjjBZLyGUB3 aILhxdynC05DaynfWju6R9014pkqSR2kjvQ/llueC9buOD72Uq15DKf6XyUrdfqUQvSG IAUy2wgQPbvP15hRUbnGz7qRMEDgATaZ4arvOqou0BjjHowGoFPHrf4nWYU1R5zVIxpZ +CQPXL2MOmzafqxzgM+wHHMCdoZP6/OHeGhgCaIJZ3kWh2LWjB6/dGSCXPJlvD3ZHLwP xfV4lhnF22xVmiAFx1zwYAzWyql9rKAmo2NqZV+JycJasus9f72Po1zZpR6ALrLLqr9x lDlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=UC/EoX03ceQZeX9QVLAiKEvcDFmh8FIGe76XPutT7dU=; b=TY2gLkTjocyQqepwC5BHk6Du6YuhraSKWKf/IrcSgpc8XhGkqhUz3qdJTwf6i2yFob W46Xh+BVHxM3fHH1wXe7RQ4V7odTjk1MGcmblT4pVPNd5zgkgE5uuMz2OMVDrkUf3sBH EubnvP0vBf8a+X9WYY2usmD7cx6rc25+zL7senFO6UbQEnydFfbDx0CTnUV9uyJgDM1k qmDvfYyMt+WuW8xzmjbeoQRQVblRstmSy+bSbAWhGdS7CRnl4Ta8TQ8BMxVj126WKeLw S/Ua9+rdJTs3fmKqUnOyg/EtXU28BYTpxDv5RFUiTK9N7QamkK9evKhYddAN5SamR7+X dIGA== X-Gm-Message-State: AOPr4FViJXL8FBFe4HBIYabFtcleqpkWnzyMEUoxgycQIzMHq/DLUYw7YncsHhhOVDYREw== X-Received: by 10.98.17.153 with SMTP id 25mr24887475pfr.105.1463160793769; Fri, 13 May 2016 10:33:13 -0700 (PDT) Received: from vm-dev.localdomain ([208.91.1.34]) by smtp.gmail.com with ESMTPSA id k65sm28849127pfj.31.2016.05.13.10.33.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 May 2016 10:33:12 -0700 (PDT) X-CudaMail-Envelope-Sender: u9012063@gmail.com From: William Tu To: dev@openvswitch.org X-CudaMail-MID: CM-V2-512033243 X-CudaMail-DTE: 051316 X-CudaMail-Originating-IP: 209.85.192.196 Date: Fri, 13 May 2016 10:33:07 -0700 X-ASG-Orig-Subj: [##CM-V2-512033243##][PATCH] ovsdb-server: Fix memory leak reported by Valgind. Message-Id: <1463160787-82530-1-git-send-email-u9012063@gmail.com> X-Mailer: git-send-email 2.5.0 X-GBUdb-Analysis: 0, 209.85.192.196, Ugly c=0.291963 p=-0.0588235 Source Normal X-MessageSniffer-Rules: 0-0-0-3953-c X-Barracuda-Connect: UNKNOWN[192.168.14.1] X-Barracuda-Start-Time: 1463160794 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.60 X-Barracuda-Spam-Status: No, SCORE=0.60 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.0 tests=BSF_SC5_MJ1963, DKIM_SIGNED, MAILTO_TO_SPAM_ADDR, RDNS_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.29549 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 DKIM_SIGNED Domain Keys Identified Mail: message has a signature 0.00 MAILTO_TO_SPAM_ADDR URI: Includes a link to a likely spammer email 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS 0.50 BSF_SC5_MJ1963 Custom Rule MJ1963 Subject: [ovs-dev] [PATCH] ovsdb-server: Fix memory leak reported by Valgind. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" Reported by test 1657: ovsdb-server/add-db and remove-db. ds_put_format (dynamic-string.c:142) query_db_remotes (ovsdb-server.c:798) reconfigure_remotes (ovsdb-server.c:988) main_loop (ovsdb-server.c:156) Signed-off-by: William Tu --- ovsdb/ovsdb-server.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c index 4e2c8d0..0ec3053 100644 --- a/ovsdb/ovsdb-server.c +++ b/ovsdb/ovsdb-server.c @@ -196,6 +196,7 @@ main_loop(struct ovsdb_jsonrpc_server *jsonrpc, struct shash *all_dbs, } } + free(remotes_error); } int