| Message ID | 1463066619-30813-1-git-send-email-guru@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
"dev" <dev-bounces@openvswitch.org> wrote on 05/12/2016 10:23:39 AM: > From: Gurucharan Shetty <guru@ovn.org> > To: dev@openvswitch.org > Cc: Gurucharan Shetty <guru@ovn.org> > Date: 05/12/2016 10:42 AM > Subject: [ovs-dev] [PATCH] tests: Add valgrind targets for ovn > utilities and dameons. > Sent by: "dev" <dev-bounces@openvswitch.org> > > Signed-off-by: Gurucharan Shetty <guru@ovn.org> > --- > tests/automake.mk | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tests/automake.mk b/tests/automake.mk > index a5c6074..211a80d 100644 > --- a/tests/automake.mk > +++ b/tests/automake.mk > @@ -152,6 +152,10 @@ check-lcov: all tests/atconfig tests/atlocal $ > (TESTSUITE) $(check_DATA) clean-lc > # valgrind support > > valgrind_wrappers = \ > + tests/valgrind/ovn-controller \ > + tests/valgrind/ovn-nbctl \ > + tests/valgrind/ovn-northd \ > + tests/valgrind/ovn-sbctl \ > tests/valgrind/ovs-appctl \ > tests/valgrind/ovs-ofctl \ > tests/valgrind/ovstest \ > -- This makes a lot of sense to me, we should especially be checking the daemons... Acked-by: Ryan Moats <rmoats@us.ibm.com>
Thanks for adding this, I will re-run the OVN-related valgrind tests. On Thu, May 12, 2016 at 9:14 AM, Ryan Moats <rmoats@us.ibm.com> wrote: > > > "dev" <dev-bounces@openvswitch.org> wrote on 05/12/2016 10:23:39 AM: > > > From: Gurucharan Shetty <guru@ovn.org> > > To: dev@openvswitch.org > > Cc: Gurucharan Shetty <guru@ovn.org> > > Date: 05/12/2016 10:42 AM > > Subject: [ovs-dev] [PATCH] tests: Add valgrind targets for ovn > > utilities and dameons. > > Sent by: "dev" <dev-bounces@openvswitch.org> > > > > Signed-off-by: Gurucharan Shetty <guru@ovn.org> > > --- > > tests/automake.mk | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/tests/automake.mk b/tests/automake.mk > > index a5c6074..211a80d 100644 > > --- a/tests/automake.mk > > +++ b/tests/automake.mk > > @@ -152,6 +152,10 @@ check-lcov: all tests/atconfig tests/atlocal $ > > (TESTSUITE) $(check_DATA) clean-lc > > # valgrind support > > > > valgrind_wrappers = \ > > + tests/valgrind/ovn-controller \ > > + tests/valgrind/ovn-nbctl \ > > + tests/valgrind/ovn-northd \ > > + tests/valgrind/ovn-sbctl \ > > tests/valgrind/ovs-appctl \ > > tests/valgrind/ovs-ofctl \ > > tests/valgrind/ovstest \ > > -- > > This makes a lot of sense to me, we should especially be checking the > daemons... > > Acked-by: Ryan Moats <rmoats@us.ibm.com> > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
Thank you William and Ryan. I pushed this to master. On 12 May 2016 at 09:32, William Tu <u9012063@gmail.com> wrote: > Thanks for adding this, I will re-run the OVN-related valgrind tests. > > On Thu, May 12, 2016 at 9:14 AM, Ryan Moats <rmoats@us.ibm.com> wrote: > > > > > > > "dev" <dev-bounces@openvswitch.org> wrote on 05/12/2016 10:23:39 AM: > > > > > From: Gurucharan Shetty <guru@ovn.org> > > > To: dev@openvswitch.org > > > Cc: Gurucharan Shetty <guru@ovn.org> > > > Date: 05/12/2016 10:42 AM > > > Subject: [ovs-dev] [PATCH] tests: Add valgrind targets for ovn > > > utilities and dameons. > > > Sent by: "dev" <dev-bounces@openvswitch.org> > > > > > > Signed-off-by: Gurucharan Shetty <guru@ovn.org> > > > --- > > > tests/automake.mk | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/tests/automake.mk b/tests/automake.mk > > > index a5c6074..211a80d 100644 > > > --- a/tests/automake.mk > > > +++ b/tests/automake.mk > > > @@ -152,6 +152,10 @@ check-lcov: all tests/atconfig tests/atlocal $ > > > (TESTSUITE) $(check_DATA) clean-lc > > > # valgrind support > > > > > > valgrind_wrappers = \ > > > + tests/valgrind/ovn-controller \ > > > + tests/valgrind/ovn-nbctl \ > > > + tests/valgrind/ovn-northd \ > > > + tests/valgrind/ovn-sbctl \ > > > tests/valgrind/ovs-appctl \ > > > tests/valgrind/ovs-ofctl \ > > > tests/valgrind/ovstest \ > > > -- > > > > This makes a lot of sense to me, we should especially be checking the > > daemons... > > > > Acked-by: Ryan Moats <rmoats@us.ibm.com> > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > http://openvswitch.org/mailman/listinfo/dev > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
diff --git a/tests/automake.mk b/tests/automake.mk index a5c6074..211a80d 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -152,6 +152,10 @@ check-lcov: all tests/atconfig tests/atlocal $(TESTSUITE) $(check_DATA) clean-lc # valgrind support valgrind_wrappers = \ + tests/valgrind/ovn-controller \ + tests/valgrind/ovn-nbctl \ + tests/valgrind/ovn-northd \ + tests/valgrind/ovn-sbctl \ tests/valgrind/ovs-appctl \ tests/valgrind/ovs-ofctl \ tests/valgrind/ovstest \
Signed-off-by: Gurucharan Shetty <guru@ovn.org> --- tests/automake.mk | 4 ++++ 1 file changed, 4 insertions(+)