diff mbox

[ovs-dev] Build Windows include runtime

Message ID 1456495153-11268-1-git-send-email-aserdean@cloudbasesolutions.com
State Accepted
Headers show

Commit Message

Alin Serdean Feb. 26, 2016, 1:59 p.m. UTC
This patch adds the Visual Studio runtime to the binaries by adding
the code generation compile flags: MT (release version) and MTd (debug
version).

More on the subject can be found under:
https://msdn.microsoft.com/en-us/library/2kzt1wy3%28v=vs.120%29.aspx

This helps shipping binaries and guaranteeing the runtime uses the specific
version

Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
---
 build-aux/cccl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ben Pfaff March 14, 2016, 5:25 p.m. UTC | #1
On Fri, Feb 26, 2016 at 01:59:10PM +0000, Alin Serdean wrote:
> This patch adds the Visual Studio runtime to the binaries by adding
> the code generation compile flags: MT (release version) and MTd (debug
> version).
> 
> More on the subject can be found under:
> https://msdn.microsoft.com/en-us/library/2kzt1wy3%28v=vs.120%29.aspx
> 
> This helps shipping binaries and guaranteeing the runtime uses the specific
> version
> 
> Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>

I applied this to master, since it got one ack and one question that
seemed to have a reasonable answer.
Alin Serdean March 14, 2016, 6:49 p.m. UTC | #2
Ty!

> -----Mesaj original-----
> De la: Ben Pfaff [mailto:blp@ovn.org]
> Trimis: Monday, March 14, 2016 7:25 PM
> Către: Alin Serdean <aserdean@cloudbasesolutions.com>
> Cc: dev@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] Build Windows include runtime
> 
> On Fri, Feb 26, 2016 at 01:59:10PM +0000, Alin Serdean wrote:
> > This patch adds the Visual Studio runtime to the binaries by adding
> > the code generation compile flags: MT (release version) and MTd (debug
> > version).
> >
> > More on the subject can be found under:
> > https://msdn.microsoft.com/en-us/library/2kzt1wy3%28v=vs.120%29.aspx
> >
> > This helps shipping binaries and guaranteeing the runtime uses the
> > specific version
> >
> > Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
> 
> I applied this to master, since it got one ack and one question that seemed to
> have a reasonable answer.
diff mbox

Patch

diff --git a/build-aux/cccl b/build-aux/cccl
index afa0a6b..93f9c50 100644
--- a/build-aux/cccl
+++ b/build-aux/cccl
@@ -90,11 +90,11 @@  EOF
         ;;
 
     -O0)
-        clopt="$clopt ${slash}Od ${slash}D_DEBUG"
+        clopt="$clopt ${slash}Od ${slash}D_DEBUG ${slash}MTd"
         ;;
 
     -O2)
-        clopt="$clopt ${slash}O2"
+        clopt="$clopt ${slash}O2 ${slash}MT"
         ;;
 
     -L*)