| Message ID | 1456197999-14343-1-git-send-email-fbl@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Feb 23, 2016 at 12:26:39AM -0300, Flavio Leitner wrote: > Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.") > Signed-off-by: Flavio Leitner <fbl@redhat.com> > --- > rhel/openvswitch-fedora.spec.in | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Simon Horman <simon.horman@netronome.com> > diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in > index 00e491b..34d8712 100644 > --- a/rhel/openvswitch-fedora.spec.in > +++ b/rhel/openvswitch-fedora.spec.in > @@ -359,6 +359,9 @@ rm -rf $RPM_BUILD_ROOT > %{_bindir}/ovn-northd > %{_bindir}/ovn-sbctl > %{_datadir}/openvswitch/scripts/ovn-ctl > +%{_datadir}/openvswitch/scripts/ovn-bugtool-nbctl-show > +%{_datadir}/openvswitch/scripts/ovn-bugtool-sbctl-lflow-list > +%{_datadir}/openvswitch/scripts/ovn-bugtool-sbctl-show > %{_mandir}/man8/ovs-testcontroller.8* > %{_mandir}/man5/ovn-nb.5* > %{_mandir}/man5/ovn-sb.5* > -- > 2.5.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
On Mon, Feb 22, 2016 at 11:23 PM, Simon Horman <simon.horman@netronome.com> wrote: > On Tue, Feb 23, 2016 at 12:26:39AM -0300, Flavio Leitner wrote: > > Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.") > > Signed-off-by: Flavio Leitner <fbl@redhat.com> > > --- > > rhel/openvswitch-fedora.spec.in | 3 +++ > > 1 file changed, 3 insertions(+) > > Reviewed-by: Simon Horman <simon.horman@netronome.com> > I haven't seen Reviewed-by used for OVS at all. Acked-by seems to be used for all code reviews. Should this be Acked-by, or would you like to propose the addition of Reviewed-by to CONTRIBUTING.md?
On Mon, Feb 22, 2016 at 10:26 PM, Flavio Leitner <fbl@redhat.com> wrote: > Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.") > Signed-off-by: Flavio Leitner <fbl@redhat.com> > --- > rhel/openvswitch-fedora.spec.in | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Russell Bryant <russell@ovn.org> I'd push to master, but I had a question about Simon's "Reviewed-by" header.
On Tue, Feb 23, 2016 at 9:57 AM, Russell Bryant <russell@ovn.org> wrote: > > On Mon, Feb 22, 2016 at 10:26 PM, Flavio Leitner <fbl@redhat.com> wrote: > >> Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.") >> Signed-off-by: Flavio Leitner <fbl@redhat.com> >> --- >> rhel/openvswitch-fedora.spec.in | 3 +++ >> 1 file changed, 3 insertions(+) >> > > Acked-by: Russell Bryant <russell@ovn.org> > > I'd push to master, but I had a question about Simon's "Reviewed-by" > header. > I went ahead and pushed this to master, adding Simon's review as "Acked-by". Hopefully you're OK with that! :-)
On Tue, Feb 23, 2016 at 10:06:34AM -0500, Russell Bryant wrote: > On Tue, Feb 23, 2016 at 9:57 AM, Russell Bryant <russell@ovn.org> wrote: > > > > > On Mon, Feb 22, 2016 at 10:26 PM, Flavio Leitner <fbl@redhat.com> wrote: > > > >> Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.") > >> Signed-off-by: Flavio Leitner <fbl@redhat.com> > >> --- > >> rhel/openvswitch-fedora.spec.in | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > > > > Acked-by: Russell Bryant <russell@ovn.org> > > > > I'd push to master, but I had a question about Simon's "Reviewed-by" > > header. > > > > I went ahead and pushed this to master, adding Simon's review as > "Acked-by". Hopefully you're OK with that! :-) Yes, I'm completely fine with that. There is nothing special about this and I should have used Acked-by.
On Wed, 24 Feb 2016 08:59:03 +0900 Simon Horman <simon.horman@netronome.com> wrote: > On Tue, Feb 23, 2016 at 10:06:34AM -0500, Russell Bryant wrote: > > On Tue, Feb 23, 2016 at 9:57 AM, Russell Bryant <russell@ovn.org> wrote: > > > > > > > > On Mon, Feb 22, 2016 at 10:26 PM, Flavio Leitner <fbl@redhat.com> wrote: > > > > > >> Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.") > > >> Signed-off-by: Flavio Leitner <fbl@redhat.com> > > >> --- > > >> rhel/openvswitch-fedora.spec.in | 3 +++ > > >> 1 file changed, 3 insertions(+) > > >> > > > > > > Acked-by: Russell Bryant <russell@ovn.org> > > > > > > I'd push to master, but I had a question about Simon's "Reviewed-by" > > > header. > > > > > > > I went ahead and pushed this to master, adding Simon's review as > > "Acked-by". Hopefully you're OK with that! :-) > > Yes, I'm completely fine with that. > There is nothing special about this and I should have used Acked-by. Thanks guys! :-)
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 00e491b..34d8712 100644 --- a/rhel/openvswitch-fedora.spec.in +++ b/rhel/openvswitch-fedora.spec.in @@ -359,6 +359,9 @@ rm -rf $RPM_BUILD_ROOT %{_bindir}/ovn-northd %{_bindir}/ovn-sbctl %{_datadir}/openvswitch/scripts/ovn-ctl +%{_datadir}/openvswitch/scripts/ovn-bugtool-nbctl-show +%{_datadir}/openvswitch/scripts/ovn-bugtool-sbctl-lflow-list +%{_datadir}/openvswitch/scripts/ovn-bugtool-sbctl-show %{_mandir}/man8/ovs-testcontroller.8* %{_mandir}/man5/ovn-nb.5* %{_mandir}/man5/ovn-sb.5*
Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.") Signed-off-by: Flavio Leitner <fbl@redhat.com> --- rhel/openvswitch-fedora.spec.in | 3 +++ 1 file changed, 3 insertions(+)