diff mbox

[ovs-dev,3/3] ovsdb: avoid unnecessary call ovsdb_monitor_get_update()

Message ID 1456131994-377-3-git-send-email-azhou@ovn.org
State Superseded
Headers show

Commit Message

Andy Zhou Feb. 22, 2016, 9:06 a.m. UTC 
Avoid calling ovsdb_monitor_get_update() if there aren't any unflushed
transactions.

Reported-by: Liran Schour <lirans@il.ibm.com>
Signed-off-by: Andy Zhou <azhou@ovn.org>
---
 ovsdb/jsonrpc-server.c | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox

Patch

diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c
index 0d23b77..6f46dbc 100644
--- a/ovsdb/jsonrpc-server.c
+++ b/ovsdb/jsonrpc-server.c
@@ -1297,6 +1297,10 @@  static struct json *
 ovsdb_jsonrpc_monitor_compose_update(struct ovsdb_jsonrpc_monitor *m,
                                      bool initial)
 {
+    if (!ovsdb_monitor_needs_flush(m->dbmon, m->unflushed)) {
+        return NULL;
+    }
+
     return ovsdb_monitor_get_update(m->dbmon, initial, &m->unflushed,
                                     m->version);
 }