| Message ID | 1453875675-64654-1-git-send-email-u9012063@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
This patch is obviously correct, but the commit that introduced the bug is from October, and I've never seen the error you mention. Where do you see it? On Tue, Jan 26, 2016 at 10:21:15PM -0800, William Tu wrote: > The current build fails at this test case: > /usr/bin/m4:tests/ovs-vswitchd.at:171: recursion limit of 1024 exceeded, > use -L<N> to change it > autom4te: /usr/bin/m4 failed with exit status: 1 > > Signed-off-by: William Tu <u9012063@gmail.com> > --- > tests/ovs-vswitchd.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/ovs-vswitchd.at b/tests/ovs-vswitchd.at > index 492b944..4245fc4 100644 > --- a/tests/ovs-vswitchd.at > +++ b/tests/ovs-vswitchd.at > @@ -168,7 +168,7 @@ dnl ---------------------------------------------------------------------- > dnl OVSDB server before release version 2.5 does not support the monitor2 > dnl method. This test defeatures the OVSDB server to simulate an older > dnl OVSDB server and make sure ovs-vswitchd can still work with it > -AT_SETUP([ovs-vswitchd -- Compatible with OVSDB server - w/o monitor2)]) > +AT_SETUP([ovs-vswitchd -- Compatible with OVSDB server - w/o monitor2]) > OVS_VSWITCHD_START > > dnl defeature OVSDB server -- no monitor2 > -- > 2.5.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
Hi Ben, I installed ovs on one of my physical machine and after "./boot.sh;./configure;make", this error shows up. The machine has: - CentOS release 6.5 (Final) - m4 (GNU M4) 1.4.13 Regards, William On Tue, Jan 26, 2016 at 10:30 PM, Ben Pfaff <blp@ovn.org> wrote: > This patch is obviously correct, but the commit that introduced the bug > is from October, and I've never seen the error you mention. Where do > you see it? > > On Tue, Jan 26, 2016 at 10:21:15PM -0800, William Tu wrote: > > The current build fails at this test case: > > /usr/bin/m4:tests/ovs-vswitchd.at:171: recursion limit of 1024 exceeded, > > use -L<N> to change it > > autom4te: /usr/bin/m4 failed with exit status: 1 > > > > Signed-off-by: William Tu <u9012063@gmail.com> > > --- > > tests/ovs-vswitchd.at | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/ovs-vswitchd.at b/tests/ovs-vswitchd.at > > index 492b944..4245fc4 100644 > > --- a/tests/ovs-vswitchd.at > > +++ b/tests/ovs-vswitchd.at > > @@ -168,7 +168,7 @@ dnl > ---------------------------------------------------------------------- > > dnl OVSDB server before release version 2.5 does not support the > monitor2 > > dnl method. This test defeatures the OVSDB server to simulate an older > > dnl OVSDB server and make sure ovs-vswitchd can still work with it > > -AT_SETUP([ovs-vswitchd -- Compatible with OVSDB server - w/o monitor2)]) > > +AT_SETUP([ovs-vswitchd -- Compatible with OVSDB server - w/o monitor2]) > > OVS_VSWITCHD_START > > > > dnl defeature OVSDB server -- no monitor2 > > -- > > 2.5.0 > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > http://openvswitch.org/mailman/listinfo/dev >
Hmm, maybe it's the antique version of m4, 1.4.13 was released in 2009. Or possibly a similarly antique version of Autoconf. Anyway, thanks for the report, I added some details below to the commit message and applied this to master. The problem isn't on older branches. On Tue, Jan 26, 2016 at 11:17:05PM -0800, William Tu wrote: > Hi Ben, > > I installed ovs on one of my physical machine and after > "./boot.sh;./configure;make", this error shows up. The machine has: > - CentOS release 6.5 (Final) > - m4 (GNU M4) 1.4.13 > > Regards, > William > > > On Tue, Jan 26, 2016 at 10:30 PM, Ben Pfaff <blp@ovn.org> wrote: > > > This patch is obviously correct, but the commit that introduced the bug > > is from October, and I've never seen the error you mention. Where do > > you see it? > > > > On Tue, Jan 26, 2016 at 10:21:15PM -0800, William Tu wrote: > > > The current build fails at this test case: > > > /usr/bin/m4:tests/ovs-vswitchd.at:171: recursion limit of 1024 exceeded, > > > use -L<N> to change it > > > autom4te: /usr/bin/m4 failed with exit status: 1 > > > > > > Signed-off-by: William Tu <u9012063@gmail.com> > > > --- > > > tests/ovs-vswitchd.at | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tests/ovs-vswitchd.at b/tests/ovs-vswitchd.at > > > index 492b944..4245fc4 100644 > > > --- a/tests/ovs-vswitchd.at > > > +++ b/tests/ovs-vswitchd.at > > > @@ -168,7 +168,7 @@ dnl > > ---------------------------------------------------------------------- > > > dnl OVSDB server before release version 2.5 does not support the > > monitor2 > > > dnl method. This test defeatures the OVSDB server to simulate an older > > > dnl OVSDB server and make sure ovs-vswitchd can still work with it > > > -AT_SETUP([ovs-vswitchd -- Compatible with OVSDB server - w/o monitor2)]) > > > +AT_SETUP([ovs-vswitchd -- Compatible with OVSDB server - w/o monitor2]) > > > OVS_VSWITCHD_START > > > > > > dnl defeature OVSDB server -- no monitor2 > > > -- > > > 2.5.0 > > > > > > _______________________________________________ > > > dev mailing list > > > dev@openvswitch.org > > > http://openvswitch.org/mailman/listinfo/dev > >
diff --git a/tests/ovs-vswitchd.at b/tests/ovs-vswitchd.at index 492b944..4245fc4 100644 --- a/tests/ovs-vswitchd.at +++ b/tests/ovs-vswitchd.at @@ -168,7 +168,7 @@ dnl ---------------------------------------------------------------------- dnl OVSDB server before release version 2.5 does not support the monitor2 dnl method. This test defeatures the OVSDB server to simulate an older dnl OVSDB server and make sure ovs-vswitchd can still work with it -AT_SETUP([ovs-vswitchd -- Compatible with OVSDB server - w/o monitor2)]) +AT_SETUP([ovs-vswitchd -- Compatible with OVSDB server - w/o monitor2]) OVS_VSWITCHD_START dnl defeature OVSDB server -- no monitor2
The current build fails at this test case: /usr/bin/m4:tests/ovs-vswitchd.at:171: recursion limit of 1024 exceeded, use -L<N> to change it autom4te: /usr/bin/m4 failed with exit status: 1 Signed-off-by: William Tu <u9012063@gmail.com> --- tests/ovs-vswitchd.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)