diff mbox

[ovs-dev,06/41] openflow-1.2: Remove unused struct definition.

Message ID 1453188448-2437-7-git-send-email-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff Jan. 19, 2016, 7:26 a.m. UTC
Experimenter stats are handled by code in ofp-msgs, and this struct isn't
good for anything.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 include/openflow/openflow-1.2.h | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Jarno Rajahalme Jan. 19, 2016, 7:40 p.m. UTC | #1
Acked-by: Jarno Rajahalme <jarno@ovn.org>

> On Jan 18, 2016, at 11:26 PM, Ben Pfaff <blp@ovn.org> wrote:
> 
> Experimenter stats are handled by code in ofp-msgs, and this struct isn't
> good for anything.
> 
> Signed-off-by: Ben Pfaff <blp@ovn.org>
> ---
> include/openflow/openflow-1.2.h | 9 ---------
> 1 file changed, 9 deletions(-)
> 
> diff --git a/include/openflow/openflow-1.2.h b/include/openflow/openflow-1.2.h
> index 65417d6..30e220c 100644
> --- a/include/openflow/openflow-1.2.h
> +++ b/include/openflow/openflow-1.2.h
> @@ -172,15 +172,6 @@ enum ofp12_group_capabilities {
>     OFPGFC12_CHAINING_CHECKS = 1 << 3, /* Check chaining for loops and delete */
> };
> 
> -/* Body for ofp12_stats_request/reply of type OFPST_EXPERIMENTER. */
> -struct ofp12_experimenter_stats_header {
> -    ovs_be32 experimenter;    /* Experimenter ID which takes the same form
> -                                 as in struct ofp_experimenter_header. */
> -    ovs_be32 exp_type;        /* Experimenter defined. */
> -    /* Experimenter-defined arbitrary additional data. */
> -};
> -OFP_ASSERT(sizeof(struct ofp12_experimenter_stats_header) == 8);
> -
> /* Role request and reply message. */
> struct ofp12_role_request {
>     ovs_be32 role;            /* One of OFPCR12_ROLE_*. */
> -- 
> 2.1.3
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
diff mbox

Patch

diff --git a/include/openflow/openflow-1.2.h b/include/openflow/openflow-1.2.h
index 65417d6..30e220c 100644
--- a/include/openflow/openflow-1.2.h
+++ b/include/openflow/openflow-1.2.h
@@ -172,15 +172,6 @@  enum ofp12_group_capabilities {
     OFPGFC12_CHAINING_CHECKS = 1 << 3, /* Check chaining for loops and delete */
 };
 
-/* Body for ofp12_stats_request/reply of type OFPST_EXPERIMENTER. */
-struct ofp12_experimenter_stats_header {
-    ovs_be32 experimenter;    /* Experimenter ID which takes the same form
-                                 as in struct ofp_experimenter_header. */
-    ovs_be32 exp_type;        /* Experimenter defined. */
-    /* Experimenter-defined arbitrary additional data. */
-};
-OFP_ASSERT(sizeof(struct ofp12_experimenter_stats_header) == 8);
-
 /* Role request and reply message. */
 struct ofp12_role_request {
     ovs_be32 role;            /* One of OFPCR12_ROLE_*. */